Some koans are missing

[hantuzun]

There are some koans in clojure-koans[1] that are missing from clojurescript-koans. Can we add these koans to this project?

[1] https://github.com/functional-koans/clojure-koans/tree/master/src/koans

[lazerwalker]

For the most part, I originally omitted any koan that depends on a Clojure language feature that isn't present in ClojureScript (the "java interop" section being the most obvious candidate, but I recall there were subtler issues with a number of other koans).

If there are koans that are missing that are doable in ClojureScript, I'm more than happy to accept a PR that reintroduces them. Are there specific koans you're thinking of?

[hantuzun]

I could be missing something but I think group-by koans [1] could be added, group-by is also in core.cljs [2]. But yes, the other two, "macros" and "java interop" are Clojure dependent.

[1] https://github.com/functional-koans/clojure-koans/blob/master/src/koans/21_group_by.clj
[2] https://github.com/clojure/clojurescript/blob/master/src/cljs/cljs/core.cljs#L8451-L8461

[lazerwalker]

Ah, looks like the the group-by koans weren't added until January, well after I'd built this:
functional-koans/clojure-koans@d6b1b57#diff-19871b15398b86c1185582aa793808ad

Sounds 👍 to me if you want to add them!

On Thu, Oct 23, 2014 at 11:29 AM, Emrehan Tuzun notifications@github.com
wrote:

I could be missing something but I think group-by koans [1] could be
added, group-by is also in core.cljs [2]. But yes, the other two, "macros"
and "java interop" are Clojure dependent.

[1]
https://github.com/functional-koans/clojure-koans/blob/master/src/koans/21_group_by.clj
[2]
https://github.com/clojure/clojurescript/blob/master/src/cljs/cljs/core.cljs#L8451-L8461

—
Reply to this email directly or view it on GitHub
#8 (comment)
.

[hantuzun]

Great, I'll open a PR in a week.