Limit trigger names to 64 characters. (#33)

* Rename "bootstrap" to "migrate" mode

Fixes #18

* Limit trigger names to 64 characters.

Fixes #32

Author: jcjones

partitionmanager/cli_test.py

@@ -559,13 +559,13 @@ def test_migrate_cmd_in(self):
                         + "`p_20210521` VALUES LESS THAN (300), PARTITION "
                         + "`p_20210620` VALUES LESS THAN MAXVALUE);",
                         "CREATE OR REPLACE TRIGGER copy_inserts_from_"
-                        + "partitioned_yesterday_to_partitioned_yesterday_new_20210421",
+                        + "partitioned_yesterday_to_partitioned_yesterday",
                         "\tAFTER INSERT ON partitioned_yesterday FOR EACH ROW",
                         "\t\tINSERT INTO partitioned_yesterday_new_20210421 SET",
                         "\t\t\t`id` = NEW.`id`,",
                         "\t\t\t`serial` = NEW.`serial`;",
                         "CREATE OR REPLACE TRIGGER copy_updates_from_"
-                        + "partitioned_yesterday_to_partitioned_yesterday_new_20210421",
+                        + "partitioned_yesterday_to_partitioned_yesterday",
                         "\tAFTER UPDATE ON partitioned_yesterday FOR EACH ROW",
                         "\t\tUPDATE partitioned_yesterday_new_20210421 SET",
                         "\t\t\t`serial` = NEW.`serial`",

partitionmanager/migrate.py

@@ -137,6 +137,11 @@ def _trigger_column_copies(cols):
         yield f"`{c}` = NEW.`{c}`"
 
 
+def _make_trigger_name(name):
+    """ Helper that enforces the trigger must be <= 64 chars """
+    return name[:64]
+
+
 def _generate_sql_copy_commands(
     existing_table, map_data, columns, new_table, alter_commands_iter
 ):
@@ -175,7 +180,11 @@ def _generate_sql_copy_commands(
 
     cols = set(columns)
 
-    yield f"CREATE OR REPLACE TRIGGER copy_inserts_from_{existing_table.name}_to_{new_table.name}"
+    inserts_trigger_name = _make_trigger_name(
+        f"copy_inserts_from_{existing_table.name}_to_{new_table.name}"
+    )
+
+    yield f"CREATE OR REPLACE TRIGGER {inserts_trigger_name}"
     yield f"\tAFTER INSERT ON {existing_table.name} FOR EACH ROW"
     yield f"\t\tINSERT INTO {new_table.name} SET"
 
@@ -192,7 +201,11 @@ def _generate_sql_copy_commands(
         log.info("No columns to copy, so no UPDATE trigger being constructed.")
         return
 
-    yield f"CREATE OR REPLACE TRIGGER copy_updates_from_{existing_table.name}_to_{new_table.name}"
+    updates_trigger_name = _make_trigger_name(
+        f"copy_updates_from_{existing_table.name}_to_{new_table.name}"
+    )
+
+    yield f"CREATE OR REPLACE TRIGGER {updates_trigger_name}"
     yield f"\tAFTER UPDATE ON {existing_table.name} FOR EACH ROW"
     yield f"\t\tUPDATE {new_table.name} SET"