Skip to content

Commit 0c6401a

Browse files
committed
[benchmarks] Minor repairs.
1 parent 35ad9b0 commit 0c6401a

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

.github/actions/run-benchmarks/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ runs:
6666
cd ..
6767
if [[ -z $EXISTING_FILE ]]; then
6868
mkdir -p ${{ inputs.repo-for-saving-data }}/$OUTPUT_DIR
69-
echo "The collected benchmark results will be saved to $OUTPUT_FILE."
69+
echo "The collected benchmark results will be saved to $OUTPUT_DIR/$OUTPUT_FILENAME."
7070
echo "::set-output name=output-file::$OUTPUT_DIR/$OUTPUT_FILENAME"
7171
else
7272
echo "The benchmark will not be run because results for that commit are already saved at $EXISTING_FILE."

.github/actions/visualize-save-upload/action.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,14 @@ runs:
6161
if [ -f errors.txt ]; then
6262
ERROR_MESSAGES=$(cat errors.txt)
6363
echo "The benchmark runner reported the following errors:\n$ERROR_MESSAGES"
64-
echo "::set-output name=error-messages::Error messages: $ERROR_MESSAGES"
64+
ERROR_MESSAGES=$(cat << EOF
65+
Error messages:
66+
$ERROR_MESSAGES
67+
EOF
68+
)
69+
echo "ERROR_MESSAGES<<EOF" >> $GITHUB_ENV
70+
echo "$ERROR_MESSAGES" >> $GITHUB_ENV
71+
echo "EOF" >> $GITHUB_ENV
6572
fi
6673
shell: bash
6774

@@ -70,7 +77,7 @@ runs:
7077
with:
7178
message: |
7279
Running benchmarks from commit ${{ github.sha }}...
73-
${{ steps.compute-error-messages.outputs.error-messages }}
80+
${{ env.ERROR_MESSAGES }}
7481
7582
Results so far:
7683
@@ -85,7 +92,7 @@ runs:
8592
with:
8693
message: |
8794
:heavy_check_mark: Finished running benchmarks from ${{ github.sha }}.
88-
${{ steps.compute-error-messages.outputs.error-messages }}
95+
${{ env.ERROR_MESSAGES }}
8996
9097
![Visualization of the benchmark results.](https://raw.githubusercontent.com/lf-lang/${{ inputs.repo-for-saving-data }}/saved-benchmark-results/${{ steps.figure.outputs.output-file }})
9198
comment_includes: ${{ github.sha }}

0 commit comments

Comments
 (0)