Skip to content

Commit 8994c5c

Browse files
committed
[benchmarks] Minor repairs.
1 parent 35ad9b0 commit 8994c5c

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/actions/run-benchmarks/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ runs:
6666
cd ..
6767
if [[ -z $EXISTING_FILE ]]; then
6868
mkdir -p ${{ inputs.repo-for-saving-data }}/$OUTPUT_DIR
69-
echo "The collected benchmark results will be saved to $OUTPUT_FILE."
69+
echo "The collected benchmark results will be saved to $OUTPUT_DIR/$OUTPUT_FILENAME."
7070
echo "::set-output name=output-file::$OUTPUT_DIR/$OUTPUT_FILENAME"
7171
else
7272
echo "The benchmark will not be run because results for that commit are already saved at $EXISTING_FILE."

.github/actions/visualize-save-upload/action.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,10 @@ runs:
6161
if [ -f errors.txt ]; then
6262
ERROR_MESSAGES=$(cat errors.txt)
6363
echo "The benchmark runner reported the following errors:\n$ERROR_MESSAGES"
64-
echo "::set-output name=error-messages::Error messages: $ERROR_MESSAGES"
64+
ERROR_MESSAGES="Error messages:\n$ERROR_MESSAGES"
65+
echo 'ERROR_MESSAGES<<EOF' >> $GITHUB_ENV
66+
echo $ERROR_MESSAGES >> $GITHUB_ENV
67+
echo 'EOF' >> $GITHUB_ENV
6568
fi
6669
shell: bash
6770

@@ -70,7 +73,7 @@ runs:
7073
with:
7174
message: |
7275
Running benchmarks from commit ${{ github.sha }}...
73-
${{ steps.compute-error-messages.outputs.error-messages }}
76+
${{ env.ERROR_MESSAGES }}
7477
7578
Results so far:
7679
@@ -85,7 +88,7 @@ runs:
8588
with:
8689
message: |
8790
:heavy_check_mark: Finished running benchmarks from ${{ github.sha }}.
88-
${{ steps.compute-error-messages.outputs.error-messages }}
91+
${{ env.ERROR_MESSAGES }}
8992
9093
![Visualization of the benchmark results.](https://raw.githubusercontent.com/lf-lang/${{ inputs.repo-for-saving-data }}/saved-benchmark-results/${{ steps.figure.outputs.output-file }})
9194
comment_includes: ${{ github.sha }}

0 commit comments

Comments
 (0)