Clean up legacy MetaDataUpdater and ConnectorTypeSerde (prestodb#25652)

## Description
1. Extract the cleanup from prestodb#25242 

## Motivation and Context
1. clean up the codebase
2. separate concern from the original pr

## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->

## Test Plan
1. passed verifier test
2. 
## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.

## Release Notes

```
== NO RELEASE NOTE ==
```

Author: shangm2

presto-hive-hadoop2/src/test/java/com/facebook/presto/hive/s3select/S3SelectTestHelper.java

@@ -30,7 +30,6 @@
 import com.facebook.presto.hive.HiveColumnHandle;
 import com.facebook.presto.hive.HiveCommonClientConfig;
 import com.facebook.presto.hive.HiveEncryptionInformationProvider;
-import com.facebook.presto.hive.HiveFileRenamer;
 import com.facebook.presto.hive.HiveHdfsConfiguration;
 import com.facebook.presto.hive.HiveLocationService;
 import com.facebook.presto.hive.HiveMetadataFactory;
@@ -178,7 +177,6 @@ public S3SelectTestHelper(String host,
                 new HivePartitionObjectBuilder(),
                 new HiveEncryptionInformationProvider(ImmutableSet.of()),
                 new HivePartitionStats(),
-                new HiveFileRenamer(),
                 columnConverterProvider,
                 new QuickStatsProvider(metastoreClient, hdfsEnvironment, DO_NOTHING_DIRECTORY_LISTER, new HiveClientConfig(), new NamenodeStats(), ImmutableList.of()),
                 new HiveTableWritabilityChecker(config));

presto-hive/pom.xml

@@ -160,11 +160,6 @@
             <scope>test</scope>
         </dependency>
 
-        <dependency>
-            <groupId>com.facebook.drift</groupId>
-            <artifactId>drift-api</artifactId>
-        </dependency>
-
         <dependency>
             <groupId>com.google.guava</groupId>
             <artifactId>guava</artifactId>
@@ -267,11 +262,6 @@
             <artifactId>jackson-databind</artifactId>
         </dependency>
 
-        <dependency>
-            <groupId>javax.annotation</groupId>
-            <artifactId>javax.annotation-api</artifactId>
-        </dependency>
-
         <dependency>
             <groupId>org.roaringbitmap</groupId>
             <artifactId>RoaringBitmap</artifactId>

presto-hive/src/main/java/com/facebook/presto/hive/ForUpdatingHiveMetadata.java

@@ -169,8 +169,6 @@ public class HiveClientConfig
     private DataSize pageFileStripeMaxSize = new DataSize(24, MEGABYTE);
     private boolean parquetDereferencePushdownEnabled;
 
-    private int maxMetadataUpdaterThreads = 100;
-
     private boolean isPartialAggregationPushdownEnabled;
     private boolean isPartialAggregationPushdownForVariableLengthDatatypesEnabled;
 
@@ -683,6 +681,7 @@ public HiveClientConfig setMaxPartitionsPerWriter(int maxPartitionsPerWriter)
         this.maxPartitionsPerWriter = maxPartitionsPerWriter;
         return this;
     }
+
     public int getWriteValidationThreads()
     {
         return writeValidationThreads;
@@ -1372,19 +1371,6 @@ public boolean isParquetDereferencePushdownEnabled()
         return this.parquetDereferencePushdownEnabled;
     }
 
-    @Min(1)
-    public int getMaxMetadataUpdaterThreads()
-    {
-        return maxMetadataUpdaterThreads;
-    }
-
-    @Config("hive.max-metadata-updater-threads")
-    public HiveClientConfig setMaxMetadataUpdaterThreads(int maxMetadataUpdaterThreads)
-    {
-        this.maxMetadataUpdaterThreads = maxMetadataUpdaterThreads;
-        return this;
-    }
-
     @Config("hive.partial_aggregation_pushdown_enabled")
     @ConfigDescription("enable partial aggregation pushdown")
     public HiveClientConfig setPartialAggregationPushdownEnabled(boolean partialAggregationPushdownEnabled)

presto-hive/src/main/java/com/facebook/presto/hive/HiveClientConfig.java

@@ -69,13 +69,11 @@
 import com.facebook.presto.parquet.cache.ParquetCacheConfig;
 import com.facebook.presto.parquet.cache.ParquetFileMetadata;
 import com.facebook.presto.parquet.cache.ParquetMetadataSource;
-import com.facebook.presto.spi.connector.ConnectorMetadataUpdaterProvider;
 import com.facebook.presto.spi.connector.ConnectorNodePartitioningProvider;
 import com.facebook.presto.spi.connector.ConnectorPageSinkProvider;
 import com.facebook.presto.spi.connector.ConnectorPageSourceProvider;
 import com.facebook.presto.spi.connector.ConnectorPlanOptimizerProvider;
 import com.facebook.presto.spi.connector.ConnectorSplitManager;
-import com.facebook.presto.spi.connector.ConnectorTypeSerdeProvider;
 import com.google.common.cache.Cache;
 import com.google.common.cache.CacheBuilder;
 import com.google.common.collect.ImmutableList;
@@ -98,7 +96,6 @@
 import static com.facebook.airlift.configuration.ConfigBinder.configBinder;
 import static com.facebook.airlift.json.JsonCodecBinder.jsonCodecBinder;
 import static com.facebook.airlift.json.smile.SmileCodecBinder.smileCodecBinder;
-import static com.facebook.drift.codec.guice.ThriftCodecBinder.thriftCodecBinder;
 import static com.facebook.presto.orc.StripeMetadataSource.CacheableRowGroupIndices;
 import static com.facebook.presto.orc.StripeMetadataSource.CacheableSlice;
 import static com.google.common.util.concurrent.MoreExecutors.listeningDecorator;
@@ -152,9 +149,6 @@ public void configure(Binder binder)
         binder.bind(HiveWriterStats.class).in(Scopes.SINGLETON);
         newExporter(binder).export(HiveWriterStats.class).as(generatedNameOf(HiveWriterStats.class, connectorId));
 
-        binder.bind(HiveFileRenamer.class).in(Scopes.SINGLETON);
-        newExporter(binder).export(HiveFileRenamer.class).as(generatedNameOf(HiveFileRenamer.class, connectorId));
-
         newSetBinder(binder, EventClient.class).addBinding().to(HiveEventClient.class).in(Scopes.SINGLETON);
         binder.bind(HivePartitionManager.class).in(Scopes.SINGLETON);
         newExporter(binder).export(HivePartitionManager.class).withGeneratedName();
@@ -177,11 +171,8 @@ public void configure(Binder binder)
         binder.bind(ConnectorPageSinkProvider.class).to(HivePageSinkProvider.class).in(Scopes.SINGLETON);
         binder.bind(ConnectorNodePartitioningProvider.class).to(HiveNodePartitioningProvider.class).in(Scopes.SINGLETON);
         binder.bind(ConnectorPlanOptimizerProvider.class).to(HivePlanOptimizerProvider.class).in(Scopes.SINGLETON);
-        binder.bind(ConnectorMetadataUpdaterProvider.class).to(HiveMetadataUpdaterProvider.class).in(Scopes.SINGLETON);
-        binder.bind(ConnectorTypeSerdeProvider.class).to(HiveConnectorTypeSerdeProvider.class).in(Scopes.SINGLETON);
         binder.install(new ThriftCodecModule());
         binder.install(new DefaultThriftCodecsModule());
-        thriftCodecBinder(binder).bindThriftCodec(HiveMetadataUpdateHandle.class);
 
         jsonCodecBinder(binder).bindJsonCodec(PartitionUpdate.class);
         smileCodecBinder(binder).bindSmileCodec(PartitionUpdate.class);
@@ -261,14 +252,6 @@ public ExecutorService createCachingHiveMetastoreExecutor(HiveConnectorId hiveCl
                 daemonThreadsNamed("hive-metastore-" + hiveClientId + "-%s"));
     }
 
-    @ForUpdatingHiveMetadata
-    @Singleton
-    @Provides
-    public ExecutorService createUpdatingHiveMetadataExecutor(HiveConnectorId hiveClientId)
-    {
-        return newCachedThreadPool(daemonThreadsNamed("hive-metadata-updater-" + hiveClientId + "-%s"));
-    }
-
     @ForFileRename
     @Singleton
     @Provides

presto-hive/src/main/java/com/facebook/presto/hive/HiveClientModule.java

@@ -22,14 +22,12 @@
 import com.facebook.presto.spi.connector.ConnectorCapabilities;
 import com.facebook.presto.spi.connector.ConnectorCommitHandle;
 import com.facebook.presto.spi.connector.ConnectorMetadata;
-import com.facebook.presto.spi.connector.ConnectorMetadataUpdaterProvider;
 import com.facebook.presto.spi.connector.ConnectorNodePartitioningProvider;
 import com.facebook.presto.spi.connector.ConnectorPageSinkProvider;
 import com.facebook.presto.spi.connector.ConnectorPageSourceProvider;
 import com.facebook.presto.spi.connector.ConnectorPlanOptimizerProvider;
 import com.facebook.presto.spi.connector.ConnectorSplitManager;
 import com.facebook.presto.spi.connector.ConnectorTransactionHandle;
-import com.facebook.presto.spi.connector.ConnectorTypeSerdeProvider;
 import com.facebook.presto.spi.connector.classloader.ClassLoaderSafeConnectorMetadata;
 import com.facebook.presto.spi.procedure.Procedure;
 import com.facebook.presto.spi.session.PropertyMetadata;
@@ -73,8 +71,6 @@ public class HiveConnector
     private final ConnectorAccessControl accessControl;
     private final ClassLoader classLoader;
     private final ConnectorPlanOptimizerProvider planOptimizerProvider;
-    private final ConnectorMetadataUpdaterProvider metadataUpdaterProvider;
-    private final ConnectorTypeSerdeProvider connectorTypeSerdeProvider;
 
     private final HiveTransactionManager transactionManager;
 
@@ -94,8 +90,6 @@ public HiveConnector(
             List<PropertyMetadata<?>> analyzeProperties,
             ConnectorAccessControl accessControl,
             ConnectorPlanOptimizerProvider planOptimizerProvider,
-            ConnectorMetadataUpdaterProvider metadataUpdaterProvider,
-            ConnectorTypeSerdeProvider connectorTypeSerdeProvider,
             ClassLoader classLoader)
     {
         this.lifeCycleManager = requireNonNull(lifeCycleManager, "lifeCycleManager is null");
@@ -114,8 +108,6 @@ public HiveConnector(
         this.accessControl = requireNonNull(accessControl, "accessControl is null");
         this.classLoader = requireNonNull(classLoader, "classLoader is null");
         this.planOptimizerProvider = requireNonNull(planOptimizerProvider, "planOptimizerProvider is null");
-        this.metadataUpdaterProvider = requireNonNull(metadataUpdaterProvider, "metadataUpdaterProvider is null");
-        this.connectorTypeSerdeProvider = requireNonNull(connectorTypeSerdeProvider, "connectorTypeSerdeProvider is null");
     }
 
     @Override
@@ -156,18 +148,6 @@ public ConnectorPlanOptimizerProvider getConnectorPlanOptimizerProvider()
         return planOptimizerProvider;
     }
 
-    @Override
-    public ConnectorMetadataUpdaterProvider getConnectorMetadataUpdaterProvider()
-    {
-        return metadataUpdaterProvider;
-    }
-
-    @Override
-    public ConnectorTypeSerdeProvider getConnectorTypeSerdeProvider()
-    {
-        return connectorTypeSerdeProvider;
-    }
-
     @Override
     public Set<SystemTable> getSystemTables()
     {

presto-hive/src/main/java/com/facebook/presto/hive/HiveConnector.java

@@ -38,13 +38,11 @@
 import com.facebook.presto.spi.connector.ConnectorAccessControl;
 import com.facebook.presto.spi.connector.ConnectorContext;
 import com.facebook.presto.spi.connector.ConnectorFactory;
-import com.facebook.presto.spi.connector.ConnectorMetadataUpdaterProvider;
 import com.facebook.presto.spi.connector.ConnectorNodePartitioningProvider;
 import com.facebook.presto.spi.connector.ConnectorPageSinkProvider;
 import com.facebook.presto.spi.connector.ConnectorPageSourceProvider;
 import com.facebook.presto.spi.connector.ConnectorPlanOptimizerProvider;
 import com.facebook.presto.spi.connector.ConnectorSplitManager;
-import com.facebook.presto.spi.connector.ConnectorTypeSerdeProvider;
 import com.facebook.presto.spi.connector.classloader.ClassLoaderSafeConnectorPageSinkProvider;
 import com.facebook.presto.spi.connector.classloader.ClassLoaderSafeConnectorPageSourceProvider;
 import com.facebook.presto.spi.connector.classloader.ClassLoaderSafeConnectorSplitManager;
@@ -158,8 +156,6 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
             ConnectorAccessControl accessControl = new SystemTableAwareAccessControl(injector.getInstance(ConnectorAccessControl.class));
             Set<Procedure> procedures = injector.getInstance(Key.get(new TypeLiteral<Set<Procedure>>() {}));
             ConnectorPlanOptimizerProvider planOptimizerProvider = injector.getInstance(ConnectorPlanOptimizerProvider.class);
-            ConnectorMetadataUpdaterProvider metadataUpdaterProvider = injector.getInstance(ConnectorMetadataUpdaterProvider.class);
-            ConnectorTypeSerdeProvider connectorTypeSerdeProvider = injector.getInstance(ConnectorTypeSerdeProvider.class);
 
             List<PropertyMetadata<?>> allSessionProperties = new ArrayList<>(hiveSessionProperties.getSessionProperties());
             allSessionProperties.addAll(hiveCommonSessionProperties.getSessionProperties());
@@ -180,8 +176,6 @@ public Connector create(String catalogName, Map<String, String> config, Connecto
                     hiveAnalyzeProperties.getAnalyzeProperties(),
                     accessControl,
                     planOptimizerProvider,
-                    metadataUpdaterProvider,
-                    connectorTypeSerdeProvider,
                     classLoader);
         }
         catch (Exception e) {