Skip to content

Discussion - My terraform support contribution may not work as intended #2

@craigthackerx

Description

@craigthackerx

Hey Gary 👋

Thanks for merging the PR! To be honest, I didn't actually think it would be merged without some comments from yourself as some of it is abit messy as it does have some requirements from my own GitHub Org.

As it is right now - you may want to revert the merge back to your own last commit since you will get emailed when it fails fail it's CI checks and whatnot since it won't have my organisation secrets, as well as using some custom terraform modules which would be nicer to be generic terraform for a repo like yours.

Although that's up to you 😄

I'll (try) prepare a new PR which will be more suitable for merge into your repo, it's more the fact I wanted to contribute something back as I found your function app hugely useful for something I was looking for in a personal project of mine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions