@@ -840,14 +840,15 @@ static const uint32_t SPSP_3[] = {
840840};
841841
842842/* SPSP to all bases < 100 */
843+ /* still needs computing
843844static const char *SPSP_2_100_LARGE[] = {
844845 "",
845846 "",
846847 "",
847848 "",
848849 ""
849850};
850-
851+ */
851852
852853/* Extra strong Lucas test with Baillie's parameters Q = 1, P = 3 */
853854static const uint32_t ESLPSP [] = {
@@ -887,26 +888,27 @@ static int test_mp_prime_miller_rabin(void)
887888{
888889 mp_int a , b , c ;
889890 bool result ;
891+ int i ;
890892 DOR (mp_init_multi (& a , & b , & c , NULL ));
891893
892894 /* SPSP to base 2 */
893895 mp_set (& b , 2u );
894- for (int i = 0 ; i < ARR_LENGTH (SPSP_2 ); i ++ ) {
896+ for (i = 0 ; i < ARR_LENGTH (SPSP_2 ); i ++ ) {
895897 result = false;
896898 mp_set_u32 (& a , SPSP_2 [i ]);
897899 DO (mp_prime_miller_rabin (& a , & b , & result ));
898900 EXPECT (result == true);
899901 }
900902
901903 /* Some larger primes to check for false negatives */
902- for (int i = 0 ; i < 10 ; i ++ ) {
904+ for (i = 0 ; i < 10 ; i ++ ) {
903905 result = false;
904906 DO (mp_read_radix (& a , medium_primes [i ], 64 ));
905907 DO (mp_prime_miller_rabin (& a , & b , & result ));
906908 EXPECT (result == true);
907909 }
908910 /* Some semi-primes */
909- for (int i = 0 ; i < 5 ; i += 2 ) {
911+ for (i = 0 ; i < 5 ; i += 2 ) {
910912 result = false;
911913 DO (mp_read_radix (& a , medium_primes [i ], 64 ));
912914 DO (mp_read_radix (& c , medium_primes [i + 1 ], 64 ));
@@ -917,7 +919,7 @@ static int test_mp_prime_miller_rabin(void)
917919
918920 /* SPSP to base 3 */
919921 mp_set (& b , 3u );
920- for (int i = 0 ; i < ARR_LENGTH (SPSP_3 ); i ++ ) {
922+ for (i = 0 ; i < ARR_LENGTH (SPSP_3 ); i ++ ) {
921923 result = false;
922924 mp_set_u32 (& a , SPSP_3 [i ]);
923925 DO (mp_prime_miller_rabin (& a , & b , & result ));
@@ -936,34 +938,36 @@ static int test_mp_prime_extra_strong_lucas(void)
936938{
937939 mp_int a , b ;
938940 bool result ;
941+ int i ;
942+
939943 DOR (mp_init_multi (& a , & b , NULL ));
940944
941945 /* Check Extra Strong pseudoprimes */
942- for (int i = 0 ; i < ARR_LENGTH (ESLPSP ); i ++ ) {
946+ for (i = 0 ; i < ARR_LENGTH (ESLPSP ); i ++ ) {
943947 result = false;
944948 mp_set_u32 (& a , ESLPSP [i ]);
945949 DO (mp_prime_extra_strong_lucas (& a , & result ));
946950 EXPECT (result == true);
947951 }
948952
949953 /* Check Almost Extra Strong pseudoprimes (not in ESLPSP) */
950- for (int i = 0 ; i < ARR_LENGTH (AESLPSP ); i ++ ) {
954+ for (i = 0 ; i < ARR_LENGTH (AESLPSP ); i ++ ) {
951955 result = false;
952956 mp_set_u32 (& a , AESLPSP [i ]);
953957 DO (mp_prime_extra_strong_lucas (& a , & result ));
954958 EXPECT (result == false);
955959 }
956960
957961 /* Some larger primes to check for false negatives */
958- for (int i = 0 ; i < 10 ; i ++ ) {
962+ for (i = 0 ; i < 10 ; i ++ ) {
959963 result = false;
960964 DO (mp_read_radix (& a , medium_primes [i ], 64 ));
961965 DO (mp_prime_extra_strong_lucas (& a , & result ));
962966 EXPECT (result == true);
963967 }
964968
965969 /* Some semi-primes */
966- for (int i = 0 ; i < 5 ; i ++ ) {
970+ for (i = 0 ; i < 5 ; i ++ ) {
967971 result = false;
968972 DO (mp_read_radix (& a , medium_primes [i ], 64 ));
969973 DO (mp_read_radix (& a , medium_primes [i + 1 ], 64 ));
@@ -1513,7 +1517,7 @@ static int test_mp_log_n(void)
15131517 mp_int a ;
15141518 mp_digit d ;
15151519 int base , lb , size ;
1516- const int max_base = MP_MIN (INT_MAX , MP_DIGIT_MAX );
1520+ const mp_digit max_base = MP_MIN (INT_MAX , MP_DIGIT_MAX );
15171521
15181522 DOR (mp_init (& a ));
15191523
0 commit comments