cluster support - v0.1.2 (#5)

* cluster support

* Linting cleanup

* fixes specs

* which => command -v

* try installing redis manually

* redis service cleanup and server shutdown

* benchmark workflow should be good

* cluster client builder specs

* don't build the cluster client if not retrying

* typo

* better comments and cleaner nodes method

Author: lifeBCE

.github/workflows/benchmark.yml

@@ -4,21 +4,40 @@
 name: CI Benchmark Test
 on: [pull_request]
 jobs:
-  test:
+  benchmark:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         ruby:
           - '3.2.0'
-    services:
-      redis:
-        image: redis
-        ports: ["6379:6379"]
     steps:
     - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
         bundler-cache: true
+    - name: Install redis
+      run: sudo apt-get install -y redis-tools redis-server
+
+    - name: Verify that redis is up
+      run: redis-cli ping
+
+    - name: Shut primary redis down
+      run: sudo systemctl stop redis
+
+    - name: Start redis cluster
+      run: bin/cluster start
+
+    - name: Create redis cluster
+      run: bin/cluster create -f
+
     - name: Run benchmark tests
       run: bundle exec ruby benchmark.rb
+      env:
+        WORKFLOW_PORT: 30001
+
+    - name: Stop redis cluster
+      run: bin/cluster stop
+
+    - name: Clean redis cluster
+      run: bin/cluster clean

.github/workflows/build.yml

@@ -4,7 +4,7 @@
 name: CI Ruby Gem Build
 on: [pull_request]
 jobs:
-  gem-build:
+  build:
     runs-on: ubuntu-latest
     strategy:
       matrix:

.github/workflows/codeql.yml

@@ -4,8 +4,7 @@
 name: CI CodeQL Analysis
 on: [pull_request]
 jobs:
-  analyze:
-    name: Analyze
+  codeql:
     runs-on: ubuntu-latest
     permissions:
       actions: read
@@ -21,6 +20,6 @@ jobs:
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3
       with:
-        languages: ${{matrix.language}}
+        languages: ${{ matrix.language }}
     - name: Perform CodeQL Analysis
       uses: github/codeql-action/analyze@v3

.github/workflows/publish.yml

@@ -8,7 +8,7 @@ on:
       - '*'
   workflow_dispatch:
 jobs:
-  gem-publish:
+  publish:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4

.github/workflows/rspec.yml

@@ -4,7 +4,7 @@
 name: CI RSpec Tests
 on: [pull_request]
 jobs:
-  test:
+  rspec:
     runs-on: ubuntu-latest
     strategy:
       matrix:

.github/workflows/rubocop.yml

@@ -4,18 +4,12 @@
 name: CI Rubocop Linting
 on: [pull_request]
 jobs:
-  build:
+  rubocop:
     runs-on: ubuntu-latest
     strategy:
       matrix:
         ruby:
           - '3.2.0'
-#    steps:
-#      - uses: actions/checkout@v2
-#      - name: Rubocop Linter Action
-#        uses: andrewmcodes/rubocop-linter-action@v3.3.0
-#        env:
-#          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     steps:
       - uses: actions/checkout@v4
       - uses: ruby/setup-ruby@v1

.gitignore

@@ -12,3 +12,6 @@
 
 # compiled gems
 *.gem
+
+# cluster stuff
+bin/.cluster_dump/

.rubocop.yml

@@ -40,4 +40,4 @@ RSpec/MultipleExpectations:
 
 # Example has too many lines. [8/5]
 RSpec/ExampleLength:
-  Max: 10
+  Max: 20

Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    redis-single-file (0.1.1)
+    redis-single-file (0.1.2)
       redis (~> 5.3.0)
+      redis-clustering (~> 5.3.0)
 
 GEM
   remote: https://rubygems.org/
@@ -32,6 +33,11 @@ GEM
       redis-client (>= 0.22.0)
     redis-client (0.23.2)
       connection_pool
+    redis-cluster-client (0.13.3)
+      redis-client (~> 0.22)
+    redis-clustering (5.3.0)
+      redis (= 5.3.0)
+      redis-cluster-client (>= 0.10.0)
     regexp_parser (2.10.0)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)

benchmark.rb

@@ -3,8 +3,10 @@
 require 'benchmark/ips'
 require 'redis_single_file'
 
-scenario_1_semaphore = RedisSingleFile.new(name: :scenario1)
-scenario_2_semaphore = RedisSingleFile.new(name: :scenario2)
+PORT = ENV['WORKFLOW_PORT'] || 6379
+
+scenario_1_semaphore = RedisSingleFile.new(name: :scenario1, port: PORT)
+scenario_2_semaphore = RedisSingleFile.new(name: :scenario2, port: PORT)
 
 Benchmark.ips do |x|
   x.report('synchronize') do
@@ -18,18 +20,18 @@
   x.report('threaded (10x)') do
     threads = 10.times.map do
       Thread.new do
-        scenario_3_semaphore = RedisSingleFile.new(name: :scenario3)
+        scenario_3_semaphore = RedisSingleFile.new(name: :scenario3, port: PORT)
         scenario_3_semaphore.synchronize { nil }
       end
     end
 
-    threads.each { _1.join(0.05) } while threads.any?(&:alive?)
+    threads.each { _1.join(0.2) } while threads.any?(&:alive?)
   end
 
   x.report('forked (10x)') do
     10.times.each do
       fork do
-        scenario_4_semaphore = RedisSingleFile.new(name: :scenario4)
+        scenario_4_semaphore = RedisSingleFile.new(name: :scenario4, port: PORT)
         scenario_4_semaphore.synchronize { nil }
       end
     end