Commit e9ad08b
committed
refactor(changelog-generator): print banner sooner
So that in the `--dry-run` without `--version` use case, you won't see
the "phony version" message before the banner:
```
Using phony version changelog-generator/v0.0.0-placeholder during --dry-run
____________________
(_) `
| |
| changelog.js |
| ============ |
| |
| Reporting |
| for duty! |
| |
|__________________|
(_)_________________)
Fetching remote tags: run with --no-update-tags to skip
```
Note that this does mean that we're showing the banner in some
situations where we didn't show it before, but I think that's ok.
Example:
```
changelog-generator ❯ bin/liferay-changelog-generator.js --invalid-option
____________________
(_) `
| |
| changelog.js |
| ============ |
| |
| Reporting |
| for duty! |
| |
|__________________|
(_)_________________)
error: Unrecognized argument --invalid-option; see --help for available options
error: Missing required option: --version; see --help for usage
zsh: exit 1 bin/liferay-changelog-generator.js --invalid-option
```1 parent 65a37c4 commit e9ad08b
1 file changed
+8
-7
lines changedLines changed: 8 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
702 | 702 | | |
703 | 703 | | |
704 | 704 | | |
705 | | - | |
706 | | - | |
707 | | - | |
708 | | - | |
709 | | - | |
710 | | - | |
711 | | - | |
712 | 705 | | |
713 | 706 | | |
714 | 707 | | |
| |||
717 | 710 | | |
718 | 711 | | |
719 | 712 | | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
720 | 721 | | |
721 | 722 | | |
722 | 723 | | |
| |||
0 commit comments