Make array deallocation approach recursive for multi-dimensional unwrapping.

Author: arik-so

bindings/LDK/Bindings.swift

@@ -1498,7 +1498,7 @@ public class Bindings {
 		var array = [[LDKRouteHop]]()
 		for index in 0..<Int(nativeType.datalen) {
 			let currentEntry = nativeType.data[index]
-			let convertedEntry = LDKCVec_RouteHopZ_to_array(nativeType: currentEntry)
+			let convertedEntry = LDKCVec_RouteHopZ_to_array(nativeType: currentEntry, deallocate: deallocate)
 			array.append(convertedEntry)
 		}
 
@@ -1582,7 +1582,7 @@ public class Bindings {
 		var array = [[UInt8]]()
 		for index in 0..<Int(nativeType.datalen) {
 			let currentEntry = nativeType.data[index]
-			let convertedEntry = LDKCVec_u8Z_to_array(nativeType: currentEntry)
+			let convertedEntry = LDKCVec_u8Z_to_array(nativeType: currentEntry, deallocate: deallocate)
 			array.append(convertedEntry)
 		}
 
@@ -3046,7 +3046,7 @@ public class Bindings {
 		var array = [[UInt8]]()
 		for index in 0..<Int(nativeType.datalen) {
 			let currentEntry = nativeType.data[index]
-			let convertedEntry = LDKTransaction_to_array(nativeType: currentEntry)
+			let convertedEntry = LDKTransaction_to_array(nativeType: currentEntry, deallocate: deallocate)
 			array.append(convertedEntry)
 		}
 

src/conversion_helper.py

@@ -334,7 +334,7 @@ def prepare_return_value(cls, return_type, is_clone_method = False, is_trait_ins
 		if rust_return_type is not None and rust_return_type.startswith('LDK') and return_type_string.startswith('['):
 			return_prefix = f'Bindings.{rust_return_type}_to_array(nativeType: '
 			return_suffix = ')'
-			if rust_return_type.startswith('LDKCVec_') and is_raw_property_getter:
+			if (rust_return_type.startswith('LDKCVec_') or rust_return_type == 'LDKTransaction') and is_raw_property_getter:
 				return_suffix = ', deallocate: false)'
 		elif return_type.swift_raw_type.startswith('(UInt8'):
 			# TODO: get array length

src/generators/option_generator.py

@@ -343,7 +343,7 @@ def prepare_return_body(self, type_details):
 		if current_return_type.rust_obj is not None and current_return_type.rust_obj.startswith('LDK') and current_return_type.swift_type.startswith('['):
 			return_type_wrapper_prefix = f'Bindings.{current_return_type.rust_obj}_to_array(nativeType: '
 			return_type_wrapper_suffix = ')'
-			if current_return_type.rust_obj.startswith('LDKCVec_'):
+			if current_return_type.rust_obj.startswith('LDKCVec_') or current_return_type.rust_obj == 'LDKTransaction':
 				return_type_wrapper_suffix = ', deallocate: false)'
 			current_replacement = current_replacement.replace('return self.cOpaqueStruct!.varName', f'return {return_type_wrapper_prefix}self.cOpaqueStruct!.varName{return_type_wrapper_suffix}')
 		elif current_return_type.swift_raw_type.startswith('(UInt8'):

src/generators/util_generators/vector_generator.py

@@ -40,6 +40,8 @@ def generate_vector(self, vector_name, vector_type_details):
 				swift_primitive = deepest_iteratee.name
 			if dimensions > 1:
 				conversion_call = f'let convertedEntry = {shallowmost_iteratee.name}_to_array(nativeType: currentEntry)'
+				if shallowmost_iteratee.name.startswith('LDKCVec_') or shallowmost_iteratee.name == 'LDKTransaction':
+					conversion_call = f'let convertedEntry = {shallowmost_iteratee.name}_to_array(nativeType: currentEntry, deallocate: deallocate)'
 				pointerTypeName = shallowmost_iteratee.name
 				subdimension_prefix = ''
 				subdimension_suffix = '.cOpaqueStruct!'