Skip to content

Conversation

@tnull
Copy link
Contributor

@tnull tnull commented Aug 19, 2025

We bump the MSRV to 1.75.0 as most of our HTTP dependencies already require this, and we already require it for lightning-transaction-sync / LDK Node.

As we can do this then, we bump the reqwest dependency to 0.12 (which is nice as most other projects have by now, allowing us to not keep multiple versions in the tree).

@tnull tnull requested review from jkczyz and tankyleo August 19, 2025 09:22
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 19, 2025

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull force-pushed the 2025-08-bump-reqwest branch from d886342 to 455e666 Compare August 19, 2025 09:33
@tnull tnull force-pushed the 2025-08-bump-reqwest branch from 455e666 to c5599bc Compare August 19, 2025 09:43
@tnull tnull removed the request for review from jkczyz August 19, 2025 09:43
@tnull tnull changed the title Bump reqwest, enable client-side timeouts Bump MSRV and reqwest dependency Aug 19, 2025
Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! Do we want RUSTFLAGS=--cfg=genproto cargo +1.75.0 build to work ? Otherwise LGTM

@tnull
Copy link
Contributor Author

tnull commented Aug 20, 2025

Thank you ! Do we want RUSTFLAGS=--cfg=genproto cargo +1.75.0 build to work ? Otherwise LGTM

Hmm, not sure tbh? Do you think we should? Also, should we add a CI that runs genproto and checks the output is up-to-date, i.e., requiring any PRs going forward to update the types.rs as we go, similar to running rustfmt?

@tnull tnull requested a review from tankyleo August 20, 2025 07:07
Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure tbh? Do you think we should?

Upon further thought, I don't think it's necessary since this is a developer command; first update API definition, then update src/types.rs.

Also, should we add a CI that runs genproto and checks the output is up-to-date, i.e., requiring any PRs going forward to update the types.rs as we go, similar to running rustfmt?

Certainly yes - I'll take care of this in a follow-up thank you.

@tankyleo tankyleo merged commit e2aab92 into lightningdevkit:main Aug 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants