Apply reviews

- hack/convert-diffdisk-to-asif.sh: Add description of script.
- pkg/driver/vz: Refine error text on detecting unexpected image type.

Signed-off-by: Norio Nomura <norio.nomura@gmail.com>

Author: norio-nomura

hack/convert-diffdisk-to-asif.sh

@@ -3,6 +3,10 @@
 # SPDX-FileCopyrightText: Copyright The Lima Authors
 # SPDX-License-Identifier: Apache-2.0
 
+# This script converts the diffdisk of a Lima instance to ASIF format.
+# It requires that the instance is stopped before conversion.
+# Usage: hack/convert-diffdisk-to-asif.sh [instance-name]
+
 set -eux -o pipefail
 
 instance="${1:-asif-test}"

pkg/driver/vz/vm_darwin.go

@@ -14,6 +14,7 @@ import (
 	"os"
 	"path/filepath"
 	"runtime"
+	"slices"
 	"strconv"
 	"sync"
 	"syscall"
@@ -22,6 +23,7 @@ import (
 	"github.com/coreos/go-semver/semver"
 	"github.com/docker/go-units"
 	"github.com/lima-vm/go-qcow2reader"
+	"github.com/lima-vm/go-qcow2reader/image"
 	"github.com/lima-vm/go-qcow2reader/image/asif"
 	"github.com/lima-vm/go-qcow2reader/image/raw"
 	"github.com/sirupsen/logrus"
@@ -452,8 +454,9 @@ func validateDiskFormat(diskPath string) error {
 	if err != nil {
 		return fmt.Errorf("failed to detect the format of %q: %w", diskPath, err)
 	}
-	if t := img.Type(); t != raw.Type && t != asif.Type {
-		return fmt.Errorf("expected the format of %q to be %q, got %q", diskPath, raw.Type, t)
+	supportedDiskTypes := []image.Type{raw.Type, asif.Type}
+	if t := img.Type(); !slices.Contains(supportedDiskTypes, t) {
+		return fmt.Errorf("expected the format of %q to be one of %v, got %q", diskPath, supportedDiskTypes, t)
 	}
 	// TODO: ensure that the disk is formatted with GPT or ISO9660
 	return nil