Is the comment in resolve_a
method still up to date?
#9227
Unanswered
spacewander
asked this question in
Show and tell
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
When I read the source code of linkerd, I find the comment says:
https://github.com/linkerd/linkerd2-proxy/blob/77b98754908faeeb2ef90d20403f8e06103eba04/linkerd/dns/src/lib.rs#L105
However, the
self.dns.lookup_ip
willPerforms a dual-stack DNS lookup for the IP for the given hostname
: https://docs.rs/trust-dns-resolver/0.21.2/trust_dns_resolver/lookup_ip/index.htmlAnd the default lookup strategy is
Ipv4thenIpv6
: https://docs.rs/trust-dns-resolver/0.21.2/trust_dns_resolver/config/enum.LookupIpStrategy.html#method.default AFAIK, there is not the other place changing the default strategy in linkerd.So in fact the resolve_a method will resolve A first and then resolve AAAA.
If I am correct, maybe we can update the comment?
Beta Was this translation helpful? Give feedback.
All reactions