dracut: do not install dracut module in non-hostonly by default #1660
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In non-hostonly (generic) dracut invocation, only add rdma dracut module to the generated initramfs if it is explicitly requested. Signed-off-by: Jo Zzsi <jozzsicsataban@gmail.com>
Contributor
Author
|
There is very little testing and documentation (and willingness to improve - see #1649) of the rdma dracut module in non-hostonly mode. Let's at least do not install it by default. |
Member
|
I'm OK with this idea, if someone wants to support host only options for the special cases that need rdma to be setup from the initrd they can come later and figure out what that means for them. It is a pretty rare config already, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In non-hostonly (generic) dracut invocation, only add rdma dracut module to the generated initramfs if it is explicitly requested.