From 3a522e85dcaec5fbb1e669d0732b62beee49a8ac Mon Sep 17 00:00:00 2001 From: Stephen BOLIVAR Date: Thu, 31 Jul 2025 12:06:01 -0400 Subject: [PATCH 1/3] fix: assign new sequence number for Split() parts > 1 --- pdu/SubmitSM.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pdu/SubmitSM.go b/pdu/SubmitSM.go index 03b35af..7fc4d57 100644 --- a/pdu/SubmitSM.go +++ b/pdu/SubmitSM.go @@ -76,7 +76,10 @@ func (c *SubmitSM) Split() (multiSubSM []*SubmitSM, err error) { esmClass = c.EsmClass | data.SM_UDH_GSM // must set to indicate UDH } - for _, msg := range multiMsg { + for i, msg := range multiMsg { + if i > 0 { + c.base.Header.AssignSequenceNumber() + } multiSubSM = append(multiSubSM, &SubmitSM{ base: c.base, ServiceType: c.ServiceType, From 72864fcc05f2eaeed4d583cfa88027e64d39ddc1 Mon Sep 17 00:00:00 2001 From: Stephen BOLIVAR Date: Fri, 19 Sep 2025 16:05:35 -0400 Subject: [PATCH 2/3] fix: size 160 for msgs --- data/pkg.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/pkg.go b/data/pkg.go index 43f6eeb..c45c72c 100644 --- a/data/pkg.go +++ b/data/pkg.go @@ -5,7 +5,7 @@ import ( "sync/atomic" ) -//nolint +// nolint const ( SM_CONNID_LEN = 16 SM_MSG_LEN = 254 @@ -25,7 +25,7 @@ const ( SM_MAX_CNT_DEST_ADDR = 254 // GSM specific, short message must be no larger than 140 octets - SM_GSM_MSG_LEN = 140 + SM_GSM_MSG_LEN = 160 CONNECTION_CLOSED = 0 CONNECTION_OPENED = 1 From c26aa5a893372b00f5c8af149706f42e1ab422b5 Mon Sep 17 00:00:00 2001 From: Stephen BOLIVAR Date: Fri, 19 Sep 2025 16:19:36 -0400 Subject: [PATCH 3/3] Revert "fix: size 160 for msgs" This reverts commit 72864fcc05f2eaeed4d583cfa88027e64d39ddc1. --- data/pkg.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/pkg.go b/data/pkg.go index c45c72c..43f6eeb 100644 --- a/data/pkg.go +++ b/data/pkg.go @@ -5,7 +5,7 @@ import ( "sync/atomic" ) -// nolint +//nolint const ( SM_CONNID_LEN = 16 SM_MSG_LEN = 254 @@ -25,7 +25,7 @@ const ( SM_MAX_CNT_DEST_ADDR = 254 // GSM specific, short message must be no larger than 140 octets - SM_GSM_MSG_LEN = 160 + SM_GSM_MSG_LEN = 140 CONNECTION_CLOSED = 0 CONNECTION_OPENED = 1