Merge pull request #346 from liquidmetal-dev/fix_image_tag_release

chore: change manifest modification

Author: richardcase

.github/workflows/release.yml

@@ -40,10 +40,9 @@ jobs:
       uses: actions/checkout@v4
       with:
         fetch-depth: 0
-    - name: Update manifests
+    - name: Build release manifests
       run: |
-        # this is quite naive, but i don't think we need more for now
-        sed -i "s/dev/${TAG}/g" config/default/manager_image_patch.yaml
+        TAG=${{ env.TAG }} make manifest-modification
         kustomize build config/default/ > infrastructure-components.yaml
     - name: Release
       uses: softprops/action-gh-release@v2

Makefile

@@ -142,6 +142,22 @@ generate-manifests: $(CONTROLLER_GEN)
 		output:rbac:dir=$(RBAC_ROOT) \
 		rbac:roleName=manager-role
 
+.PHONY: manifest-modification
+manifest-modification: # Set the manifest images to the staging/production bucket.
+	$(MAKE) set-manifest-image \
+		MANIFEST_IMG=$(CONTROLLER_IMAGE) MANIFEST_TAG=$(TAG) \
+		TARGET_RESOURCE="./config/default/manager_image_patch.yaml"
+	$(MAKE) set-manifest-pull-policy PULL_POLICY=IfNotPresent TARGET_RESOURCE="./config/default/manager_pull_policy.yaml"
+
+.PHONY: set-manifest-pull-policy
+set-manifest-pull-policy:
+	$(info Updating kustomize pull policy file for manager resources)
+	sed -i'' -e 's@imagePullPolicy: .*@imagePullPolicy: '"$(PULL_POLICY)"'@' $(TARGET_RESOURCE)
+
+.PHONY: set-manifest-image
+set-manifest-image:
+	$(info Updating kustomize image patch file for manager resource)
+	sed -i'' -e 's@image: .*@image: '"${MANIFEST_IMG}:$(MANIFEST_TAG)"'@' $(TARGET_RESOURCE)
 
 ##@ Tools binaries