add cache api updateCheck

Author: lisong

config/config.js

@@ -45,8 +45,10 @@ config.development = {
     diffNums: 3,
     // data dir for caclulate diff files. it's optimization.
     dataDir: "/Users/tablee/workspaces/data",
-    //storageType which is your binary package files store. options value is ("local" | "qiniu" | "s3")
-    storageType: "local"
+    // storageType which is your binary package files store. options value is ("local" | "qiniu" | "s3")
+    storageType: "local",
+    // options value is (true | false), when it's true, it will cache updateCheck results in redis.
+    updateCheckCache: false
   },
   //config for smtp email，register module need validate user email project source https://github.com/nodemailer/nodemailer
   smtpConfig:{

config/config.test.js

@@ -19,7 +19,8 @@ config.test = {
     tryLoginTimes: 10,
     diffNums: 3,
     dataDir: os.tmpdir(),
-    storageType: "local"
+    storageType: "local",
+    updateCheckCache: true
   },
   smtpConfig: false,
   redis: {

config/config.testwin.js

@@ -19,7 +19,8 @@ config.test = {
     tryLoginTimes: 10,
     diffNums: 3,
     dataDir: os.tmpdir(),
-    storageType: "local"
+    storageType: "local",
+    updateCheckCache: true
   },
   smtpConfig: false,
   redis: {

core/services/client-manager.js

@@ -3,6 +3,7 @@ var Promise = require('bluebird');
 var models = require('../../models');
 var _ = require('lodash');
 var common = require('../utils/common');
+var factory = require('../utils/factory');
 
 var proto = module.exports = function (){
   function ClientManager() {
@@ -12,6 +13,56 @@ var proto = module.exports = function (){
   return ClientManager;
 };
 
+const UPDATE_CHECK = "UPDATE_CHECK";
+const EXPIRED = 600;
+
+proto.getUpdateCheckCacheKey = function(deploymentKey, appVersion, label, packageHash) {
+  return [UPDATE_CHECK, deploymentKey, appVersion, label, packageHash].join(':');
+}
+
+proto.clearUpdateCheckCache = function(deploymentKey, appVersion, label, packageHash) {
+  let redisCacheKey = this.getUpdateCheckCacheKey(deploymentKey, appVersion, label, packageHash);
+  var client = factory.getRedisClient("default");
+  return client.keysAsync(redisCacheKey)
+  .then(function(data) {
+    if (_.isArray(data)) {
+      return Promise.map(data, function(key){
+        return client.delAsync(key);
+      });
+    }
+    return null;
+  });
+}
+
+proto.updateCheckFromCache = function(deploymentKey, appVersion, label, packageHash) {
+  const self = this;
+  let redisCacheKey = self.getUpdateCheckCacheKey(deploymentKey, appVersion, label, packageHash);
+  var updateCheckCache = _.get(require('../config'), 'common.updateCheckCache', false);
+  if (updateCheckCache === false) {
+    return self.updateCheck(deploymentKey, appVersion, label, packageHash);
+  }
+  var client = factory.getRedisClient("default");
+  return client.getAsync(redisCacheKey)
+  .then(function(data){
+    if (data) {
+      try {
+        var obj = JSON.parse(data);
+        return obj;
+      } catch (e) {
+      }
+    }
+    return self.updateCheck(deploymentKey, appVersion, label, packageHash)
+    .then(function(rs){
+      try {
+        var strRs = JSON.stringify(rs);
+        client.setexAsync(redisCacheKey, EXPIRED, strRs);
+      } catch (e) {
+      }
+      return rs;
+    });
+  })
+}
+
 proto.updateCheck = function(deploymentKey, appVersion, label, packageHash) {
   var rs = {
     downloadURL: "",

routes/apps.js

@@ -240,6 +240,15 @@ router.post('/:appName/deployments/:deploymentName/release',
             });
           });
         }
+        //clear cache if exists.
+        if (_.get(config, 'common.updateCheckCache', false) !== false) {
+          Promise.delay(2500)
+          .then(function () {
+            var ClientManager = require('../core/services/client-manager');
+            var clientManager = new ClientManager();
+            clientManager.clearUpdateCheckCache(deploymentInfo.deployment_key, '*', '*', '*');
+          });
+        }
         return null;
       });
     });
@@ -274,6 +283,15 @@ router.post('/:appName/deployments/:sourceDeploymentName/promote/:destDeployment
       if (!destDeploymentInfo) {
         throw new Error(`${destDeploymentName}  does not exist.`);
       }
+      //clear cache if exists.
+      if (_.get(config, 'common.updateCheckCache', false) !== false) {
+        Promise.delay(2500)
+        .then(function () {
+          var ClientManager = require('../core/services/client-manager');
+          var clientManager = new ClientManager();
+          clientManager.clearUpdateCheckCache(destDeploymentInfo.deployment_key, '*', '*', '*');
+        });
+      }
       return [sourceDeploymentInfo.id, destDeploymentInfo.id];
     })
     .spread(function (sourceDeploymentId, destDeploymentId) {

routes/index.js

@@ -36,7 +36,7 @@ router.get('/updateCheck', function(req, res){
   var label = _.get(req, "query.label");
   var packageHash = _.get(req, "query.packageHash")
   var clientManager = new ClientManager();
-  clientManager.updateCheck(deploymentKey, appVersion, label, packageHash)
+  clientManager.updateCheckFromCache(deploymentKey, appVersion, label, packageHash)
   .then(function (rs) {
     res.send({"updateInfo":rs});
   })