Update QUIC draft references to RFC references #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates QUIC implementation comments to replace outdated draft references with their finalized RFC equivalents. The changes are purely documentary, updating references to reflect the publication of QUIC core specifications as RFCs 9000 (transport), 9001 (TLS), 9114 (HTTP/3), 9204 (QPACK), 9221 (datagram), and 9369 (QUIC v2). The updates also include section titles in parentheses for improved clarity and reference some draft versions for backward compatibility.
- Updates draft-ietf-quic-transport references to RFC 9000
- Updates draft-ietf-quic-tls references to RFC 9001
- Updates draft-ietf-quic-http references to RFC 9114
- Includes fixes for several typos found during the update process
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/liblsquic/lsquic_trans_params.h | Updates transport parameter comments to RFC 9000, RFC 9221, and various draft references |
| src/liblsquic/lsquic_trans_params.c | Updates connection ID transport parameter comment to RFC 9000 |
| src/liblsquic/lsquic_stream.h | Updates stream state comments to RFC 9000 |
| src/liblsquic/lsquic_stream.c | Updates HTTP/3 frame handling comments to RFC 9114 |
| src/liblsquic/lsquic_send_ctl.c | Clarifies Google QUIC vs IETF QUIC handshake retransmission differences |
| src/liblsquic/lsquic_pr_queue.c | Updates packet format comments to RFC 9000 |
| src/liblsquic/lsquic_parse_iquic_common.c | Updates packet parsing comments to RFC 9000 and RFC 9001 |
| src/liblsquic/lsquic_parse_ietf_v1.c | Updates IETF v1 parser comments to RFC 9000 and RFC 9369 |
| src/liblsquic/lsquic_parse_Q050.c | Updates Q050 parser comments to RFC 9000 |
| src/liblsquic/lsquic_parse_Q046.c | Updates Q046 parser comments to RFC 9000 |
| src/liblsquic/lsquic_packet_ietf.h | Updates IETF packet constants comments to RFC 9000 |
| src/liblsquic/lsquic_packet_common.h | Updates frame handling comments to RFC 9000 |
| src/liblsquic/lsquic_packet_common.c | Updates packet number space comments to RFC 9001 |
| src/liblsquic/lsquic_mini_conn_ietf.h | Updates crypto buffering comment to RFC 9000 |
| src/liblsquic/lsquic_mini_conn_ietf.c | Updates mini connection handling comments to RFC 9000 |
| src/liblsquic/lsquic_ietf.h | Updates error codes and retry integrity comments to RFC 9000 and RFC 9001 |
| src/liblsquic/lsquic_hq.h | Updates HTTP/3 and QPACK comments to RFC 9114 and RFC 9204 |
| src/liblsquic/lsquic_hkdf.h | Updates HKDF and salt comments to RFC 9001 and RFC 9369 |
| src/liblsquic/lsquic_hkdf.c | Updates packet protection keys comment to RFC 9001 |
| src/liblsquic/lsquic_headers_stream.c | Updates HTTP/3 settings comment to RFC 9114 |
| src/liblsquic/lsquic_handshake.c | Updates packet protection comment to RFC 9001 |
| src/liblsquic/lsquic_full_conn_ietf.c | Updates full connection comments to RFC 9000, includes typo fix |
| src/liblsquic/lsquic_engine.c | Updates coalescing packets comment to RFC 9000 |
| src/liblsquic/lsquic_enc_sess_ietf.c | Updates encryption session comments to RFC 9001 and RFC 9369, includes typo fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@dtikhonov I've opened a new pull request, #591, to work on those changes. Once the pull request is ready, I'll request review from you. |
4 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments only -- no code changes