Skip to content
This repository was archived by the owner on Sep 24, 2025. It is now read-only.

Commit 82aaea9

Browse files
authored
Update nodejs matrix version, remove set-env and fix PR fail.
1 parent f9e6574 commit 82aaea9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.github/workflows/nodejs.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99

1010
strategy:
1111
matrix:
12-
node-version: [10.x, 12.x, 14.X]
12+
node-version: [12.x, 14.X, 16.x, 17.X]
1313

1414
steps:
1515
- name: Git checkout
@@ -30,7 +30,7 @@ jobs:
3030
run: npm test
3131

3232
- name: SonarCloud Scan
33-
if: matrix.node-version == '14.x'
33+
if: (matrix.node-version == '16.x') && (github.event_name != 'pull_request')
3434
uses: sonarsource/sonarcloud-github-action@master
3535
with:
3636
# Disabling shallow clone is recommended for improving relevancy of reporting
@@ -50,12 +50,12 @@ jobs:
5050
uses: actions/checkout@v2
5151

5252
- name: Set env
53-
run: echo ::set-env name=RELEASE_VERSION::${GITHUB_REF:10}
53+
run: echo "RELEASE_VERSION=${GITHUB_REF:10}" >> $GITHUB_ENV
5454

55-
- name: Use Node.js 14.x
55+
- name: Use Node.js 16.x
5656
uses: actions/setup-node@v1
5757
with:
58-
node-version: '14.x'
58+
node-version: '16.x'
5959

6060
- name: Install globally grunt-cli
6161
run: npm install -g grunt-cli

0 commit comments

Comments
 (0)