Skip to content

Commit 4bb9f06

Browse files
committed
Enhance Regression audit log
To help debug issues with regression creation and update, log outcomes of common operations.
1 parent 11b59eb commit 4bb9f06

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

lnt/server/db/fieldchange.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,10 @@ def identify_related_changes(session, ts, fc, active_indicators):
261261
active_indicators.append(ri)
262262
# Update the default title if needed.
263263
rebuild_title(session, ts, regression)
264+
logger.info("Updated title of Regression({}) to \"{}\"".format(regression.id, regression.title))
264265
return True, regression
265-
logger.info("Could not find a partner, creating new Regression for change")
266+
266267
new_reg, new_indicators = new_regression(session, ts, [fc.id])
268+
logger.info("Could not find a partner, creating new Regression for change: {}".format(new_reg.title))
267269
active_indicators.extend(new_indicators)
268270
return False, new_reg

lnt/server/db/regression.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from lnt.server.reporting.analysis import RunInfo
66
from lnt.server.ui.util import guess_test_short_name as shortname
77
from lnt.testing.util.commands import timed
8+
from lnt.util import logger
89

910

1011
class RegressionState:
@@ -55,6 +56,7 @@ def new_regression(session, ts, field_changes):
5556
new_ris.append(ri1)
5657
session.add_all(new_ris)
5758
rebuild_title(session, ts, regression)
59+
logger.info("Creating new Regression: {}".format(regression.title))
5860
session.commit()
5961
return regression, new_ris
6062

@@ -74,7 +76,9 @@ def rebuild_title(session, ts, regression):
7476
title = FMT.format(new_size, ', '.join(sorted(benchmarks)))
7577
# Crop long titles.
7678
title = (title[:120] + '...') if len(title) > 120 else title
79+
logger.info("Rename Regression: \"{}\" to \"{}\"".format(regression.title, title))
7780
regression.title = title
81+
7882
return regression
7983

8084

0 commit comments

Comments
 (0)