Skip to content

Commit 29c54d8

Browse files
committed
address comments
1 parent f2df981 commit 29c54d8

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

llvm/test/Transforms/InstCombine/freeze.ll

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,19 @@ define i32 @early_freeze_test4(i32 %v1) {
153153
ret i32 %v2.fr
154154
}
155155

156+
define i32 @assume(i32 %a, i32 %b) {
157+
; CHECK-LABEL: @assume(
158+
; CHECK-NEXT: call void @llvm.assume(i1 true) [ "noundef"(i32 [[A:%.*]]) ]
159+
; CHECK-NEXT: [[ADD_FR:%.*]] = freeze i32 [[ADD:%.*]]
160+
; CHECK-NEXT: [[ADD1:%.*]] = add i32 [[A]], [[ADD_FR]]
161+
; CHECK-NEXT: ret i32 [[ADD1]]
162+
;
163+
call void @llvm.assume(i1 true) [ "noundef"(i32 %a) ]
164+
%add = add nsw nuw i32 %a, %b
165+
%add.fr = freeze i32 %add
166+
ret i32 %add.fr
167+
}
168+
156169
; If replace all dominated uses of v to freeze(v).
157170

158171
define void @freeze_dominated_uses_test1(i32 %v) {

llvm/test/Transforms/LoopUnroll/Hexagon/reuse-lcssa-phi-scev-expansion.ll

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,9 @@ define void @preserve_lcssa_when_reusing_existing_phi() {
2323
; CHECK-NEXT: br i1 true, label %[[LOOP_2_LATCH:.*]], label %[[LOOP_4_PREHEADER:.*]]
2424
; CHECK: [[LOOP_4_PREHEADER]]:
2525
; CHECK-NEXT: [[IV_3_LCSSA_LCSSA1:%.*]] = phi i32 [ [[IV_3_LCSSA]], %[[PH]] ]
26-
; CHECK-NEXT: [[IV_3_LCSSA_LCSSA:%.*]] = phi i32 [ [[IV_3_LCSSA]], %[[PH]] ]
26+
; CHECK-NEXT: [[TMP2:%.*]] = phi i32 [ [[IV_3_LCSSA]], %[[PH]] ]
2727
; CHECK-NEXT: [[TMP0:%.*]] = add i32 [[IV_3_LCSSA_LCSSA1]], 1
28-
; CHECK-NEXT: [[TMP1:%.*]] = freeze i32 [[TMP0]]
29-
; CHECK-NEXT: [[TMP2:%.*]] = add i32 [[TMP1]], -1
30-
; CHECK-NEXT: [[XTRAITER:%.*]] = and i32 [[TMP1]], 7
28+
; CHECK-NEXT: [[XTRAITER:%.*]] = and i32 [[TMP0]], 7
3129
; CHECK-NEXT: [[TMP3:%.*]] = icmp ult i32 [[TMP2]], 7
3230
; CHECK-NEXT: br i1 [[TMP3]], label %[[LOOP_1_LATCH_UNR_LCSSA:.*]], label %[[LOOP_4_PREHEADER_NEW:.*]]
3331
; CHECK: [[LOOP_4_PREHEADER_NEW]]:
@@ -62,7 +60,7 @@ define void @preserve_lcssa_when_reusing_existing_phi() {
6260
; CHECK-NEXT: [[EPIL_ITER:%.*]] = phi i32 [ 0, %[[LOOP_4_EPIL_PREHEADER]] ], [ [[EPIL_ITER_NEXT:%.*]], %[[LOOP_4_EPIL]] ]
6361
; CHECK-NEXT: call void @foo()
6462
; CHECK-NEXT: [[INC_I_EPIL]] = add i32 [[IV_4_EPIL]], 1
65-
; CHECK-NEXT: [[EC_EPIL:%.*]] = icmp eq i32 [[IV_4_EPIL]], [[IV_3_LCSSA_LCSSA]]
63+
; CHECK-NEXT: [[EC_EPIL:%.*]] = icmp eq i32 [[IV_4_EPIL]], [[TMP2]]
6664
; CHECK-NEXT: [[EPIL_ITER_NEXT]] = add i32 [[EPIL_ITER]], 1
6765
; CHECK-NEXT: [[EPIL_ITER_CMP:%.*]] = icmp ne i32 [[EPIL_ITER_NEXT]], [[XTRAITER]]
6866
; CHECK-NEXT: br i1 [[EPIL_ITER_CMP]], label %[[LOOP_4_EPIL]], label %[[LOOP_1_LATCH_EPILOG_LCSSA:.*]], !llvm.loop [[LOOP0:![0-9]+]]

0 commit comments

Comments
 (0)