Skip to content

Commit 693ea8f

Browse files
committed
[runtimes] Remove dependencies on cxx_experimental for test-suite installs
This patch removes explicit dependencies on cxx_experimental for installations that are local to the test suite. Such dependencies are not required anymore from the test-suite installation targets since the proper dependency is now encoded between cxx and cxx_experimental.
1 parent 496feba commit 693ea8f

File tree

4 files changed

+3
-12
lines changed

4 files changed

+3
-12
lines changed

libcxx/src/CMakeLists.txt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -345,8 +345,8 @@ set_target_properties(cxx_experimental
345345
cxx_add_common_build_flags(cxx_experimental)
346346
target_compile_options(cxx_experimental PUBLIC -D_LIBCPP_ENABLE_EXPERIMENTAL)
347347

348-
# Add a meta-target for both libraries.
349-
add_custom_target(cxx)
348+
# Add a meta-target for both libraries and the experimental library.
349+
add_custom_target(cxx DEPENDS cxx_experimental)
350350
if (LIBCXX_ENABLE_SHARED)
351351
add_dependencies(cxx cxx_shared)
352352
endif()
@@ -389,9 +389,6 @@ if (NOT CMAKE_CONFIGURATION_TYPES)
389389
add_custom_target(install-cxx-stripped
390390
COMMAND "${CMAKE_COMMAND}" --install "${CMAKE_BINARY_DIR}" --component cxx --strip)
391391

392-
add_dependencies(install-cxx cxx_experimental)
393-
add_dependencies(install-cxx-stripped cxx_experimental)
394-
395392
if (LIBCXX_INSTALL_LIBRARY)
396393
add_dependencies(install-cxx cxx)
397394
add_dependencies(install-cxx-stripped cxx)

libcxx/test/CMakeLists.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ foreach(target IN LISTS libcxx_test_suite_install_targets)
1919
--component "${target}")
2020
add_dependencies(cxx-test-depends libcxx-test-suite-install-${target})
2121
endforeach()
22-
if (TARGET cxx_experimental)
23-
add_dependencies(libcxx-test-suite-install-cxx cxx_experimental)
24-
endif()
2522

2623
set(AUTO_GEN_COMMENT "## Autogenerated by libcxx configuration.\n# Do not edit!")
2724
set(SERIALIZED_LIT_PARAMS "# Lit parameters serialized here for llvm-lit to pick them up\n")

libcxxabi/test/CMakeLists.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ foreach(target IN LISTS libcxxabi_test_suite_install_targets)
2323
--component "${target}")
2424
add_dependencies(cxxabi-test-depends libcxxabi-test-suite-install-${target})
2525
endforeach()
26-
if (TARGET cxx_experimental)
27-
add_dependencies(libcxxabi-test-suite-install-cxx cxx_experimental)
28-
endif()
2926

3027
pythonize_bool(LIBCXXABI_USE_LLVM_UNWINDER)
3128

libunwind/test/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ endmacro()
1515
set(LIBUNWIND_TESTING_INSTALL_PREFIX "${LIBUNWIND_BINARY_DIR}/test-suite-install")
1616
set(libunwind_test_suite_install_targets unwind-headers unwind)
1717
if ("libcxx" IN_LIST LLVM_ENABLE_RUNTIMES)
18-
list(APPEND libunwind_test_suite_install_targets cxx-headers cxx cxx_experimental cxx-modules cxxabi-headers cxxabi)
18+
list(APPEND libunwind_test_suite_install_targets cxx-headers cxx cxx-modules cxxabi-headers cxxabi)
1919
endif()
2020
foreach(target IN LISTS libunwind_test_suite_install_targets)
2121
add_custom_target(libunwind-test-suite-install-${target} DEPENDS "${target}"

0 commit comments

Comments
 (0)