Skip to content

Commit 9c27399

Browse files
authored
Enable GetDimensions test for Clang & DirectX (#475)
These tests are now passing for DirectX. The SPIR-V backend does not yet support the intrinsic needed for this test, so the link now points to a new issue that is SPIR-V only.
1 parent 4484037 commit 9c27399

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

test/Feature/ByteAddressBuffer/GetDimensions.test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ DescriptorSets:
7979
...
8080
#--- end
8181

82-
# Unimplemented https://github.com/llvm/wg-hlsl/issues/126
83-
# XFAIL: Clang
82+
# Unimplemented https://github.com/llvm/llvm-project/issues/164008
83+
# XFAIL: Clang && Vulkan
8484

8585
# RUN: split-file %s %t
8686
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl

test/Feature/StructuredBuffer/GetDimensions.test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ DescriptorSets:
131131
...
132132
#--- end
133133

134-
# Unimplemented https://github.com/llvm/wg-hlsl/issues/126
135-
# XFAIL: Clang
134+
# Unimplemented https://github.com/llvm/llvm-project/issues/164008
135+
# XFAIL: Clang && Vulkan
136136

137137
# RUN: split-file %s %t
138138
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl

test/Feature/TypedBuffer/GetDimensions.test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ DescriptorSets:
8383
# Bug https://github.com/llvm/offload-test-suite/issues/469
8484
# XFAIL: DXC && Vulkan
8585

86-
# Unimplemented https://github.com/llvm/wg-hlsl/issues/126
87-
# XFAIL: Clang
86+
# Unimplemented https://github.com/llvm/llvm-project/issues/164008
87+
# XFAIL: Clang && Vulkan
8888

8989
# RUN: split-file %s %t
9090
# RUN: %dxc_target -T cs_6_5 -Fo %t.o %t/source.hlsl

0 commit comments

Comments
 (0)