From 2fe4a19ad304bdcb436fa613eb433340999508a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nikola=20Prokopi=C4=87?= Date: Fri, 13 Jun 2025 13:50:45 +0200 Subject: [PATCH 1/3] Sort and group CODEOWNERS entries --- .github/CODEOWNERS | 57 +++++++++++++++++++++++++++------------------- 1 file changed, 34 insertions(+), 23 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 4f6b0564b3..89ee56803f 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,33 +1,44 @@ * @loft-sh/eng-dev-vcluster-platform -/docs/ @loft-sh/Eng-Docs-Admin -/test/ @loft-sh/eng-qa -/.github/workflows/e2e.yaml @loft-sh/eng-qa -/.github/workflows/backport.yaml @Piotr1215 -netlify.toml @loft-sh/Eng-Docs-Admin +/.github/workflows/backport.yaml @Piotr1215 /.github/workflows/e2e.yaml @FabianKramm +/.github/workflows/e2e.yaml @loft-sh/eng-qa /.github/workflows/release.yaml @FabianKramm -/pkg/syncer/ @FabianKramm @hidalgopl -/pkg/controllers/resources/pods/ @FabianKramm -/pkg/controllers/resources/services/ @FabianKramm -/pkg/controllers/resources/endpoints/ @FabianKramm -/pkg/controllers/resources/secrets/ @FabianKramm -/pkg/controllers/resources/configmaps/ @FabianKramm -/pkg/controllers/resources/events/ @FabianKramm -/pkg/controllers/resources/*/from_host_syncer*.go @hidalgopl + +/chart/ @FabianKramm @hidalgopl + +/cmd/vcluster/ @FabianKramm @hidalgopl + +/config/ @FabianKramm @hidalgopl + +/docs/ @loft-sh/Eng-Docs-Admin + +/pkg/authentication/ @FabianKramm +/pkg/authorization/ @FabianKramm + +/pkg/cli/ @hidalgopl + +/pkg/config/ @hidalgopl +/pkg/config/config.go @FabianKramm + /pkg/controllers/k8sdefaultendpoint/ @FabianKramm /pkg/controllers/register.go @FabianKramm +/pkg/controllers/resources/*/from_host_syncer*.go @hidalgopl +/pkg/controllers/resources/configmaps/ @FabianKramm +/pkg/controllers/resources/endpoints/ @FabianKramm +/pkg/controllers/resources/events/ @FabianKramm +/pkg/controllers/resources/pods/ @FabianKramm +/pkg/controllers/resources/secrets/ @FabianKramm +/pkg/controllers/resources/services/ @FabianKramm + +/pkg/k8s/ @FabianKramm /pkg/mappings/ @FabianKramm +/pkg/plugin/ @FabianKramm /pkg/server/ @FabianKramm -/pkg/k8s/ @FabianKramm /pkg/setup/ @FabianKramm @hidalgopl -/pkg/plugin/ @FabianKramm +/pkg/syncer/ @FabianKramm @hidalgopl /pkg/util/translate/ @FabianKramm -/pkg/authentication/ @FabianKramm -/pkg/authorization/ @FabianKramm -/pkg/cli/ @hidalgopl -/pkg/config/config.go @FabianKramm -/pkg/config/ @hidalgopl -/config/ @FabianKramm @hidalgopl -/cmd/vcluster/ @FabianKramm @hidalgopl -/chart/ @FabianKramm @hidalgopl + +/test/ @loft-sh/eng-qa + +netlify.toml @loft-sh/Eng-Docs-Admin From 89a3269fd990b2a152c032214b0c1c80ce56b738 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nikola=20Prokopi=C4=87?= Date: Fri, 13 Jun 2025 13:55:06 +0200 Subject: [PATCH 2/3] Add comment about sorting and grouping --- .github/CODEOWNERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 89ee56803f..291753fcf4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,3 +1,5 @@ +# Keep the entries sorted and optionally grouped. + * @loft-sh/eng-dev-vcluster-platform /.github/workflows/backport.yaml @Piotr1215 From 0e9fa86c6659721947a73709fdaf7577bd539ee4 Mon Sep 17 00:00:00 2001 From: neogopher Date: Fri, 13 Jun 2025 18:28:33 +0530 Subject: [PATCH 3/3] add self to CODEOWNERS file --- .github/CODEOWNERS | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 291753fcf4..90ff283bd0 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -10,8 +10,11 @@ /chart/ @FabianKramm @hidalgopl /cmd/vcluster/ @FabianKramm @hidalgopl +/cmd/vclusterctl/ @neogopher -/config/ @FabianKramm @hidalgopl +/config/ @FabianKramm @hidalgopl @neogopher + +/conformance/ @neogopher /docs/ @loft-sh/Eng-Docs-Admin