Check specifically if the channel has been created

Author: estolfo

spec/inputs/redis_spec.rb

@@ -314,6 +314,8 @@ def process(conf, event_count)
 
     before { subject.register }
 
+    let(:channel_name) { 'foo' }
+
     def run_it_thread(inst)
       Thread.new(inst) do |subj|
         subj.run(queue)
@@ -342,6 +344,15 @@ def close_thread(inst, rt)
       end
     end
 
+    def wait_for_channel(timeout = 2)
+      end_time = Time.now + timeout
+      redis_client = subject.send(:new_redis_instance)
+      until redis_client.pubsub("channels").include?(channel_name)
+        break if Time.now > end_time
+        sleep(0.1)
+      end
+    end
+
     before(:example, type: :mocked) do
       subject.register
       allow_any_instance_of( Redis::Client ).to receive(:connected?).and_return true, false
@@ -368,26 +379,27 @@ def close_thread(inst, rt)
         it 'calling the run method, adds events to the queue' do
           #simulate the input thread
           rt = run_it_thread(subject)
-          sleep(0.5) # Give the subscribe request a chance to complete
+          wait_for_channel
           #simulate the other system thread
           publish_thread(subject.send(:new_redis_instance), 'c').join
           #simulate the pipeline thread
           close_thread(subject, rt).join
 
           expect(queue.size).to eq(2)
         end
+
         it 'events had redis_channel' do
           #simulate the input thread
           rt = run_it_thread(subject)
-          sleep(0.5) # Give the subscribe request a chance to complete
+          wait_for_channel
           #simulate the other system thread
           publish_thread(subject.send(:new_redis_instance), 'c').join
           #simulate the pipeline thread
           close_thread(subject, rt).join
           e1 = queue.pop
           e2 = queue.pop
-          expect(e1.get('[@metadata][redis_channel]')).to eq('foo')
-          expect(e2.get('[@metadata][redis_channel]')).to eq('foo')
+          expect(e1.get('[@metadata][redis_channel]')).to eq(channel_name)
+          expect(e2.get('[@metadata][redis_channel]')).to eq(channel_name)
         end
       end
     end
@@ -408,7 +420,7 @@ def close_thread(inst, rt)
         it 'calling the run method, adds events to the queue' do
           #simulate the input thread
           rt = run_it_thread(subject)
-          sleep(0.5) # Give the subscribe request a chance to complete
+          wait_for_channel
           #simulate the other system thread
           publish_thread(subject.send(:new_redis_instance), 'pc').join
           #simulate the pipeline thread
@@ -420,15 +432,15 @@ def close_thread(inst, rt)
         it 'events had redis_channel' do
           #simulate the input thread
           rt = run_it_thread(subject)
-          sleep(0.5) # Give the subscribe request a chance to complete
+          wait_for_channel
           #simulate the other system thread
           publish_thread(subject.send(:new_redis_instance), 'pc').join
           #simulate the pipeline thread
           close_thread(subject, rt).join
           e1 = queue.pop
           e2 = queue.pop
-          expect(e1.get('[@metadata][redis_channel]')).to eq('foo')
-          expect(e2.get('[@metadata][redis_channel]')).to eq('foo')
+          expect(e1.get('[@metadata][redis_channel]')).to eq(channel_name)
+          expect(e2.get('[@metadata][redis_channel]')).to eq(channel_name)
         end
       end
     end