refactor: Use factories for set grace days

Author: lucasdotvin

src/Models/Subscription.php

@@ -113,7 +113,7 @@ public function renew(?Carbon $expirationDate = null): self
         $graceDaysEndedAt = null;
 
         if ($this->plan->grace_days) {
-            $graceDaysEndedAt = $expirationDate->addDays($this->plan->grace_days);
+            $graceDaysEndedAt = $expirationDate->copy()->addDays($this->plan->grace_days);
         }
 
         $this->update([

tests/Models/SubscriptionTest.php

@@ -347,7 +347,12 @@ public function testModelReturnsOnlyNotCanceledSubscriptionsWithTheScope()
     public function testModelUpdatesGraceDaysEndedAtWhenRenewing()
     {
         $subscriber = User::factory()->create();
+        $plan = Plan::factory()->create([
+            'grace_days' => $graceDays = $this->faker()->randomDigitNotNull(),
+        ]);
+
         $subscription = Subscription::factory()
+            ->for($plan)
             ->for($subscriber, 'subscriber')
             ->create([
                 'grace_days_ended_at' => now()->subDay(),
@@ -357,21 +362,24 @@ public function testModelUpdatesGraceDaysEndedAtWhenRenewing()
 
         $this->assertDatabaseHas('subscriptions', [
             'id' => $subscription->id,
-            'grace_days_ended_at' => $subscription->expired_at->addDays($subscription->plan->grace_days),
+            'grace_days_ended_at' => $subscription->expired_at->addDays($graceDays),
         ]);
     }
 
     public function testModelLeavesGraceDaysEmptyWhenRenewingIfPlanDoesNotHaveIt()
     {
         $subscriber = User::factory()->create();
+        $plan = Plan::factory()->create([
+            'grace_days' => 0,
+        ]);
+
         $subscription = Subscription::factory()
+            ->for($plan)
             ->for($subscriber, 'subscriber')
             ->create([
                 'grace_days_ended_at' => null,
             ]);
 
-        $subscription->plan->update(['grace_days' => 0]);
-
         $subscription->renew();
 
         $this->assertDatabaseHas('subscriptions', [