Stop using randomDigitNotZero() formatter

Author: lucasdotvin

database/factories/FeatureFactory.php

@@ -20,7 +20,7 @@ public function definition()
         return [
             'consumable'       => $this->faker->boolean(),
             'name'             => $this->faker->words(asText: true),
-            'periodicity'      => $this->faker->randomDigitNotZero(),
+            'periodicity'      => $this->faker->randomDigitNotNull(),
             'periodicity_type' => $this->faker->randomElement([
                 PeriodicityType::Year,
                 PeriodicityType::Month,

database/factories/PlanFactory.php

@@ -19,7 +19,7 @@ public function definition()
     {
         return [
             'name'             => $this->faker->words(asText: true),
-            'periodicity'      => $this->faker->randomDigitNotZero(),
+            'periodicity'      => $this->faker->randomDigitNotNull(),
             'periodicity_type' => $this->faker->randomElement([
                 PeriodicityType::Year,
                 PeriodicityType::Month,

tests/Models/Concerns/HasSubscriptionsTest.php

@@ -301,7 +301,7 @@ public function testModelHasSubscriptionRenewals()
             ->for($subscriber, 'subscriber')
             ->createOne();
 
-        $renewalsCount = $this->faker->randomDigitNotZero();
+        $renewalsCount = $this->faker->randomDigitNotNull();
         $renewals = SubscriptionRenewal::factory()
             ->times($renewalsCount)
             ->for($subscription)

tests/Models/FeatureTest.php

@@ -18,7 +18,7 @@ public function testModelCalculateYearlyExpiration()
     {
         Carbon::setTestNow(now());
 
-        $years = $this->faker->randomDigitNotZero();
+        $years = $this->faker->randomDigitNotNull();
         $feature = Feature::factory()->create([
             'periodicity_type' => PeriodicityType::Year,
             'periodicity' => $years,
@@ -31,7 +31,7 @@ public function testModelCalculateMonthlyExpiration()
     {
         Carbon::setTestNow(now());
 
-        $months = $this->faker->randomDigitNotZero();
+        $months = $this->faker->randomDigitNotNull();
         $feature = Feature::factory()->create([
             'periodicity_type' => PeriodicityType::Month,
             'periodicity' => $months,
@@ -44,7 +44,7 @@ public function testModelCalculateWeeklyExpiration()
     {
         Carbon::setTestNow(now());
 
-        $weeks = $this->faker->randomDigitNotZero();
+        $weeks = $this->faker->randomDigitNotNull();
         $feature = Feature::factory()->create([
             'periodicity_type' => PeriodicityType::Week,
             'periodicity' => $weeks,
@@ -57,7 +57,7 @@ public function testModelCalculateDailyExpiration()
     {
         Carbon::setTestNow(now());
 
-        $days = $this->faker->randomDigitNotZero();
+        $days = $this->faker->randomDigitNotNull();
         $feature = Feature::factory()->create([
             'periodicity_type' => PeriodicityType::Day,
             'periodicity' => $days,

tests/Models/PlanTest.php

@@ -18,7 +18,7 @@ public function testModelCalculateYearlyExpiration()
     {
         Carbon::setTestNow(now());
 
-        $years = $this->faker->randomDigitNotZero();
+        $years = $this->faker->randomDigitNotNull();
         $plan = Plan::factory()->create([
             'periodicity_type' => PeriodicityType::Year,
             'periodicity' => $years,
@@ -31,7 +31,7 @@ public function testModelCalculateMonthlyExpiration()
     {
         Carbon::setTestNow(now());
 
-        $months = $this->faker->randomDigitNotZero();
+        $months = $this->faker->randomDigitNotNull();
         $plan = Plan::factory()->create([
             'periodicity_type' => PeriodicityType::Month,
             'periodicity' => $months,
@@ -44,7 +44,7 @@ public function testModelCalculateWeeklyExpiration()
     {
         Carbon::setTestNow(now());
 
-        $weeks = $this->faker->randomDigitNotZero();
+        $weeks = $this->faker->randomDigitNotNull();
         $plan = Plan::factory()->create([
             'periodicity_type' => PeriodicityType::Week,
             'periodicity' => $weeks,
@@ -57,7 +57,7 @@ public function testModelCalculateDailyExpiration()
     {
         Carbon::setTestNow(now());
 
-        $days = $this->faker->randomDigitNotZero();
+        $days = $this->faker->randomDigitNotNull();
         $plan = Plan::factory()->create([
             'periodicity_type' => PeriodicityType::Day,
             'periodicity' => $days,