Skip to content

Commit 1f2f44e

Browse files
committed
[WebXR][OpenXR] Input sources not working with hand interaction
https://bugs.webkit.org/show_bug.cgi?id=298021 Reviewed by Adrian Perez de Castro. Input sources were not properly shown inside WebXR experiences because their aim and grip poses were retrieved using an incorrect reference space. We were using the local-floor space but WebXR expects us to use the local space (i.e. without considering the floor level). * Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.cpp: (WebKit::OpenXRCoordinator::populateFrameData): Canonical link: https://commits.webkit.org/299251@main
1 parent 353f2bd commit 1f2f44e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Source/WebKit/UIProcess/XR/openxr/PlatformXROpenXR.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ PlatformXR::FrameData OpenXRCoordinator::populateFrameData(Box<RenderState> rend
669669
frameData.isPositionEmulated = !(viewState.viewStateFlags & XR_SPACE_LOCATION_POSITION_TRACKED_BIT);
670670

671671
if (m_input)
672-
frameData.inputSources = m_input->collectInputSources(renderState->frameState, m_floorSpace);
672+
frameData.inputSources = m_input->collectInputSources(renderState->frameState, m_localSpace);
673673

674674
frameData.origin = XrIdentityPose();
675675

0 commit comments

Comments
 (0)