allow passing in combined extra args to the video encoder

Author: hheimbuerger

README.md

@@ -94,16 +94,15 @@ vod:
       width: 640 # px
       height: 360 # px
       bitrate: 800 # kbps
-      # Optional ffmpeg overrides
+      # Optional ffmpeg video overrides
       codec: h264_nvenc   # default "libx264"
       preset: p1          # default "faster"
       profile: high       # default "high"
       level: auto         # default "4.0"
-      extra-args:
-        - "-tune:v"
-        - "ull"
-        - "-rc:v"
-        - "cbr"
+      extra-args:         # optionally, additional ffmpeg video encoder arguments
+        - "-tune:v=ull"   # can be passed either as combined args, and will be split
+        - "-rc:v"         # or parameter ...
+        - "cbr"           # ... and value on separate lines
     540p:
       width: 960
       height: 540

hlsvod/transcode.go

@@ -125,7 +125,16 @@ func TranscodeSegments(ctx context.Context, ffmpegBinary string, config Transcod
 
 		// extra args
 		if len(profile.ExtraArgs) > 0 {
-			args = append(args, profile.ExtraArgs...)
+			extraArgs := make([]string, 0, len(profile.ExtraArgs))
+			for _, arg := range profile.ExtraArgs {
+				// Split combined args like "-tune:v=ull" into "-tune:v", "ull"
+				if strings.Contains(arg, "=") {
+					extraArgs = append(extraArgs, strings.SplitN(arg, "=", 2)...)
+				} else {
+					extraArgs = append(extraArgs, arg)
+				}
+			}
+			args = append(args, extraArgs...)
 		}
 	}