Skip to content

Commit ff01375

Browse files
authored
Doc update: swap legacy browser names (#66)
* Update old browser references
1 parent 279055e commit ff01375

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ jobs:
104104
[curl builder](https://app.mabl.com/workspaces/-/settings/apis#api-docs-selector-dropdown-button)
105105
to find the id.
106106
- `browser-types` {string} (optional): comma or new line separated override for browser
107-
types to test e.g. `chrome, firefox, safari, internet_explorer`. If not
107+
types to test e.g. `chrome, firefox, webkit, edge`. If not
108108
provided, mabl will test the browsers configured on the triggered test.
109109
- `plan-labels` {string} (optional): comma or new line separated plan labels to test. Plans matching **any** label will be run. e.g. `smoke-test, beta-feature`. Note: additional selection criteria must also be met like application-id or environment-id, if supplied.
110110
- `uri` {string} (optional, DEPRECATED - use app_url) the base uri to run browser based tests against. If provided, this will

test/suite.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ describe('GitHub Action tests', () => {
3636
setGithubInput(ActionInputs.BrowserTypes, 'chrome, firefox ');
3737
expect(optionalArrayInput(ActionInputs.BrowserTypes)).toEqual(['chrome', 'firefox']);
3838

39-
setGithubInput(ActionInputs.BrowserTypes, 'chrome\nfirefox\nsafari ');
40-
expect(optionalArrayInput(ActionInputs.BrowserTypes)).toEqual(['chrome', 'firefox', 'safari']);
39+
setGithubInput(ActionInputs.BrowserTypes, 'chrome\nfirefox\nwebkit\nedge ');
40+
expect(optionalArrayInput(ActionInputs.BrowserTypes)).toEqual(['chrome', 'firefox', 'webkit', 'edge']);
4141
});
4242

4343
it('parses boolean inputs', () => {
@@ -123,7 +123,7 @@ describe('GitHub Action tests', () => {
123123
environment_id: 'env',
124124
application_id: 'app',
125125
plan_overrides: {
126-
browser_types: ['firefox', 'chrome', 'internet_explorer'],
126+
browser_types: ['firefox', 'chrome', 'edge'],
127127
web_url: 'fake-app-url',
128128
api_url: 'fake-api-url',
129129
},
@@ -145,7 +145,7 @@ describe('GitHub Action tests', () => {
145145
};
146146
const apiClient = new MablApiClient('test');
147147
const requestBody = apiClient.buildRequestBody(
148-
['firefox', 'chrome', 'internet_explorer'],
148+
['firefox', 'chrome', 'edge'],
149149
[],
150150
[],
151151
true,

0 commit comments

Comments
 (0)