POC for laravel/framework#31778 improve getDirty calls laravel/framework#57627

Author: Pantea Marius-ciclistu

src/Models/BaseModel.php

@@ -4,6 +4,7 @@
 
 use Carbon\Carbon;
 use Illuminate\Contracts\Database\Eloquent\CastsInboundAttributes;
+use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Cache;
@@ -47,6 +48,13 @@ abstract class BaseModel extends Model
     protected $hidden = [
         'laravel_through_key'
     ];
+
+    /**
+     * Temporary cache to avoid multiple getDirty calls generating multiple set calls for
+     * sync/merge casted attributes to objects to persist the possible changes made to those objects
+     */
+    protected ?array $tmpDirtyCache = null;
+
     private array $incrementsToRefresh = [];
 
     /**
@@ -591,6 +599,83 @@ public function syncOriginalAttributes($attributes): static
         return $this;
     }
 
+    /**
+     * @inheritdoc
+     */
+    public function isDirty($attributes = null): bool
+    {
+        return [] !== $this->getDirty(\is_array($attributes) ? $attributes : \func_get_args());
+    }
+
+    /**
+     * Get the attributes that have been changed since the last sync.
+     * @param string|array $attributes
+     * @return array
+     */
+    public function getDirty(): array
+    {
+        if (isset($this->tmpDirtyCache)) {
+            if ([] !== $args = \func_get_args()) {
+                return \array_intersect_key($this->tmpDirtyCache, \array_flip((array)$args[0]));
+            }
+
+            return $this->tmpDirtyCache;
+        }
+
+        $attributes = (array)(\func_get_args()[0] ?? \array_keys($this->attributes));
+
+        $dirty = [];
+
+        foreach ($attributes as $key) {
+            // this will merge/sync before the if condition
+            $value = $this->getAttributeFromArray($key);
+
+            if (!$this->originalIsEquivalent($key)) {
+                $dirty[$key] = $value;
+            }
+        }
+
+        return $dirty;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    protected function performUpdate(Builder $query): bool
+    {
+        if ($this->fireModelEvent('updating') === false) {
+            return false;
+        }
+
+        if ($this->usesTimestamps()) {
+            $this->updateTimestamps();
+        }
+
+        // this is needed because updating event might change the model
+        $dirty = $this->getDirtyForUpdate();
+
+        if ([] !== $dirty) {
+            $this->setKeysForSaveQuery($query)->update($dirty);
+            $this->tmpDirtyCache = $dirty;
+            $this->syncChanges();
+            unset($this->tmpDirtyCache);
+
+            $this->fireModelEvent('updated', false);
+        }
+
+        return true;
+    }
+
+    /**
+     * Get the attributes that have been changed since the last sync for an update operation.
+     *
+     * @return array
+     */
+    protected function getDirtyForUpdate(): array
+    {
+        return $this->getDirty();
+    }
+
     /**
      * Get an attribute from the $attributes array without transformation
      * @see self::getAttributeValue