POC for laravel/framework#31778 improve getDirty calls laravel/framework#57627

Author: Pantea Marius-ciclistu

illuminate/Database/Eloquent/Concerns/HasAttributes.php

@@ -64,6 +64,12 @@ trait HasAttributes
      */
     protected $changes = [];
 
+    /**
+     * Temporary cache to avoid multiple getDirty calls generating multiple set calls for
+     * sync/merge casted attributes to objects to persist the possible changes made to those objects
+     */
+    protected ?array $tmpDirtyCache = null;
+
     /**
      * The attributes that should be cast.
      *
@@ -2041,10 +2047,7 @@ public function syncChanges()
      */
     public function isDirty($attributes = null)
     {
-        return $this->hasChanges(
-            $this->getDirty(),
-            is_array($attributes) ? $attributes : func_get_args()
-        );
+        return [] !== $this->getDirty(\is_array($attributes) ? $attributes : \func_get_args());
     }
 
     /**
@@ -2114,14 +2117,27 @@ protected function hasChanges($changes, $attributes = null)
 
     /**
      * Get the attributes that have been changed since the last sync.
-     *
+     * @param string|array $attributes
      * @return array
      */
     public function getDirty()
     {
+        if (isset($this->tmpDirtyCache)) {
+            if ([] !== $args = \func_get_args()) {
+                return \array_intersect_key($this->tmpDirtyCache, \array_flip((array)$args[0]));
+            }
+
+            return $this->tmpDirtyCache;
+        }
+
+        $attributes = (array)(\func_get_args()[0] ?? \array_keys($this->attributes));
+
         $dirty = [];
 
-        foreach ($this->getAttributes() as $key => $value) {
+        foreach ($attributes as $key) {
+            // this will merge/sync before the if condition
+            $value = $this->getAttributeFromArray($key);
+
             if (!$this->originalIsEquivalent($key)) {
                 $dirty[$key] = $value;
             }

illuminate/Database/Eloquent/Model.php

@@ -995,7 +995,7 @@ function () use ($column) {
 
                 $this->fireModelEvent('updated', false);
 
-                $this->syncOriginalAttribute($column);
+                $this->syncOriginalAttributes(\array_keys($this->changes));
             }
         );
     }
@@ -1232,12 +1232,14 @@ protected function performUpdate(Builder $query)
         // Once we have run the update operation, we will fire the "updated" event for
         // this model instance. This will allow developers to hook into these after
         // models are updated, giving them a chance to do any special processing.
+        // this is needed because updating event might change the model
         $dirty = $this->getDirtyForUpdate();
 
-        if (count($dirty) > 0) {
+        if ([] !== $dirty) {
             $this->setKeysForSaveQuery($query)->update($dirty);
-
+            $this->tmpDirtyCache = $dirty;
             $this->syncChanges();
+            unset($this->tmpDirtyCache);
 
             $this->fireModelEvent('updated', false);
         }