Skip to content

[bug]: The 404 page does not always render as expected #4539

@nettree

Description

@nettree

Describe the bug

Visit https://venia.magento.com/abcdefg and see the loading component is rendered rather than 404 page

To reproduce

Steps to reproduce the behavior:

  1. Go to https://venia.magento.com/abcdefg or other path that can't be handled
  2. See error

Expected behavior

404 page should be displayed as expected when the visited URL is a 404 request, as we can see, for example, https://venia.magento.com/404

Screenshots

Image

Possible solutions

Add any ideas about possible solutions to the problem here. I had a play around inside this file:

peregrine/lib/talons/MagentoRoute/useMagentoRoute.js

If I update below code:

                if (isMounted) {
                    setRouteData(data);
                    fetchedPathname.current = pathname;
                }

To be:

                if (isMounted) {
                    fetchedPathname.current = pathname;
                    setRouteData(data);
                }

It seems to be working for me then

Debug Report

Paste the output of yarn build:report, and any other context about the problem, here.
Below is my local dev environment build report:

  ℹ  Inspecting Dependencies
    Found 9 @magento dependencies in yarn.lock
    @magento/pwa-buildpack @ 11.5.4
    @adobe/apollo-link-mutation-queue @ 1.0.2
    @magento/babel-preset-peregrine @ 1.3.3
    @magento/eslint-config @ 1.5.3
    @magento/pagebuilder @ 9.3.3
    @magento/peregrine @ 14.5.1
    @magento/pwa-theme-venia @ 2.4.0
    @magento/upward-security-headers @ 1.0.17
    @magento/venia-ui @ 11.6.0

  ℹ  Inspecting Magento Backend
    Not using sample backend.
    Backend is UP!

  ℹ  Inspecting System
    OS: #149~20.04.1-Ubuntu SMP Wed Apr 16 08:29:56 UTC 2025
    Node Version: v18.20.4
    NPM Version: 10.7.0

Please complete the following device information:

  • Device: [e.g. , PC, Mac, Pixel3]: PC
  • Browser [e.g. Chrome, Safari]: Chrome
  • Browser Version [e.g. 22]: 139.0.7258.138
  • Magento Version [e.g Adobe Commerce 2.4]: Adobe Commerce ver. 2.4.7-p6

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa

Metadata

Metadata

Assignees

Labels

Issue: Needs UpdateAdditional information is require, waiting for responseProgress: donebugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions