FIX "Implicitly marking parameter as nullable" issue (#83)

Author: enricodelazzari

src/Exceptions/InvalidMarkInstanceException.php

@@ -7,13 +7,13 @@
 
 class InvalidMarkInstanceException extends Exception
 {
-    public function __construct($message = 'Must be a Mark instance', $code = 0, Throwable $previous = null)
+    public function __construct($message = 'Must be a Mark instance', $code = 0, ?Throwable $previous = null)
     {
         parent::__construct($message, $code, $previous);
     }
 
     public static function create(): self
     {
-        return new self();
+        return new self;
     }
 }

src/Exceptions/InvalidMarkValueException.php

@@ -7,13 +7,13 @@
 
 class InvalidMarkValueException extends Exception
 {
-    public function __construct($message = 'The given mark value is not allowed.', $code = 0, Throwable $previous = null)
+    public function __construct($message = 'The given mark value is not allowed.', $code = 0, ?Throwable $previous = null)
     {
         parent::__construct($message, $code, $previous);
     }
 
     public static function create(): self
     {
-        return new self();
+        return new self;
     }
 }

src/Exceptions/InvalidMarkableInstanceException.php

@@ -7,13 +7,13 @@
 
 class InvalidMarkableInstanceException extends Exception
 {
-    public function __construct($message = 'Model must be a valid markable instance', $code = 0, Throwable $previous = null)
+    public function __construct($message = 'Model must be a valid markable instance', $code = 0, ?Throwable $previous = null)
     {
         parent::__construct($message, $code, $previous);
     }
 
     public static function create(): self
     {
-        return new self();
+        return new self;
     }
 }

src/Mark.php

@@ -42,7 +42,7 @@ public static function getMarkClassName(): string
             ->__toString();
     }
 
-    public static function add(Model $markable, Model $user, string $value = null, array $metadata = []): self
+    public static function add(Model $markable, Model $user, ?string $value = null, array $metadata = []): self
     {
         static::validMarkable($markable);
 
@@ -68,7 +68,7 @@ public static function add(Model $markable, Model $user, string $value = null, a
         return static::firstOrCreate($attributes, $values);
     }
 
-    public static function remove(Model $markable, Model $user, string $value = null)
+    public static function remove(Model $markable, Model $user, ?string $value = null)
     {
         static::validMarkable($markable);
 
@@ -80,7 +80,7 @@ public static function remove(Model $markable, Model $user, string $value = null
         ])->get()->each->delete();
     }
 
-    public static function count(Model $markable, string $value = null): int
+    public static function count(Model $markable, ?string $value = null): int
     {
         static::validMarkable($markable);
 
@@ -91,7 +91,7 @@ public static function count(Model $markable, string $value = null): int
         ])->count();
     }
 
-    public static function has(Model $markable, Model $user, string $value = null): bool
+    public static function has(Model $markable, Model $user, ?string $value = null): bool
     {
         return static::where([
             app(static::class)->getUserIdColumn() => $user->getKey(),
@@ -101,7 +101,7 @@ public static function has(Model $markable, Model $user, string $value = null):
         ])->exists();
     }
 
-    public static function toggle(Model $markable, Model $user, string $value = null, array $metadata = [])
+    public static function toggle(Model $markable, Model $user, ?string $value = null, array $metadata = [])
     {
         return static::has($markable, $user, $value)
             ? static::remove($markable, $user, $value)

src/Markable.php

@@ -25,7 +25,7 @@ public static function marks(): array
         return static::$marks ?? [];
     }
 
-    public function scopeWhereHasMark(Builder $builder, Mark $mark, Model $user, string $value = null): Builder
+    public function scopeWhereHasMark(Builder $builder, Mark $mark, Model $user, ?string $value = null): Builder
     {
         return $builder->whereHas(
             $mark->markableRelationName(),

src/Scopes/MarkableScope.php

@@ -27,7 +27,7 @@ protected function addWhereHasMark(Builder $builder, Mark $mark): void
     {
         $builder->macro(
             "whereHas{$mark::getMarkClassName()}",
-            fn (Builder $b, $user, string $value = null) => $b->whereHasMark($mark, $user, $value)
+            fn (Builder $b, $user, ?string $value = null) => $b->whereHasMark($mark, $user, $value)
         );
     }
 }

tests/Models/Article.php

@@ -12,8 +12,8 @@
 
 class Article extends Model
 {
-    use Markable;
     use HasFactory;
+    use Markable;
 
     protected static $marks = [
         Like::class,

tests/Models/Post.php

@@ -9,8 +9,8 @@
 
 class Post extends Model
 {
-    use Markable;
     use HasFactory;
+    use Markable;
 
     protected static $marks = [
         Like::class,

tests/TestCase.php

@@ -11,7 +11,7 @@
 
 class TestCase extends Orchestra
 {
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();