improve type data, and add iterator to reflect ref

Author: makspll

.vscode/settings.json

@@ -24,4 +24,4 @@
     ],
     "rust-analyzer.showUnlinkedFileNotification": false,
     // "rust-analyzer.semanticHighlighting.operator.enable": false
-}
+}

assets/scripts/bevy_api.lua

@@ -19,19 +19,26 @@ function on_event()
     local comp = world:get_component(entity, my_component_type)
     print("Before script: ", comp)
 
-
+    print("\noption")
     print(comp.option_usize)
     comp.option_usize = 69
     print(comp.option_usize)
     comp.option_usize = nil
     print(comp.option_usize)
 
-    print("vec")
-    print(comp.vec_of_usize)
-    print(comp.vec_of_usize[2])
-    comp.vec_of_usize[2] = 69
+    print("\nvec")
+    print(table_to_string(comp.vec_of_usize))
+    comp.vec_of_usize = {42,69,72}
+    comp.vec_of_usize[1] = 0
     print(comp.vec_of_usize[2])
-    world:exit()
+    print(table_to_string(comp.vec_of_usize))
+    comp.vec_of_usize = {}
+    print(table_to_string(comp.vec_of_usize))
+    comp.vec_of_usize = comp.vec_of_usize2
+    print(table_to_string(comp.vec_of_usize))
+    comp.vec_of_usize = comp.vec_of_usize
+    print(table_to_string(comp.vec_of_usize))
+
 
     print("============")
 

crates/bevy_mod_scripting_core/Cargo.toml

@@ -19,14 +19,18 @@ path = "src/lib.rs"
 # if enabled enables documentation updating in optimized builds
 doc_always = []
 
+# if enabled enables some common mlua trait implementations 
+mlua_impls = ["mlua"]
 
 [dependencies]
+mlua = { version = "0.9", optional = true }
+
 bevy = { workspace = true, default-features = false, features = ["bevy_asset"] }
 thiserror = "1.0.31"
 paste = "1.0.7"
 parking_lot = "0.12.1"
 lockable = "0.0.8"
 smallvec = "1.11"
-
+itertools = "0.13"
 [dev-dependencies]
 test_utils = { workspace = true }

crates/bevy_mod_scripting_core/src/bindings/allocator.rs

@@ -62,28 +62,28 @@ impl ReflectAllocator {
         (id, value)
     }
 
-    /// Moves the given boxed [`PartialReflect`] value into the allocator, returning an [`AllocationId`] which can be used to access it later
-    pub fn allocate_boxed(
-        &mut self,
-        existing: Box<dyn PartialReflect>,
-    ) -> (ReflectAllocationId, ReflectAllocation) {
-        let type_id = existing.get_represented_type_info().map(|i| i.type_id());
-        let id = ReflectAllocationId(self.allocations.len());
-
-        let raw_ptr = Box::into_raw(existing);
-        // Safety:
-        // - we are the only ones to have access to this value since we have the Box
-        // - UnsafeCell is repr(transparent), meaning we can safely transmute between it and the trait object
-        // TODO: I don't think we can use this, because from_raw has a pre-condition that requires the pointer to have been an arc before
-        let arc: Arc<UnsafeCell<dyn PartialReflect>> =
-            unsafe { Arc::from_raw(raw_ptr as *const _) };
-        let allocation = ReflectAllocation::new(arc);
-        self.allocations.insert(id, allocation.clone());
-        if let Some(type_id) = type_id {
-            self.types.insert(id, type_id);
-        }
-        (id, allocation)
-    }
+    // /// Moves the given boxed [`PartialReflect`] value into the allocator, returning an [`AllocationId`] which can be used to access it later
+    // pub fn allocate_boxed(
+    //     &mut self,
+    //     existing: Box<dyn PartialReflect>,
+    // ) -> (ReflectAllocationId, ReflectAllocation) {
+    //     let type_id = existing.get_represented_type_info().map(|i| i.type_id());
+    //     let id = ReflectAllocationId(self.allocations.len());
+
+    //     let raw_ptr = Box::into_raw(existing);
+    //     // Safety:
+    //     // - we are the only ones to have access to this value since we have the Box
+    //     // - UnsafeCell is repr(transparent), meaning we can safely transmute between it and the trait object
+    //     // TODO: I don't think we can use this, because from_raw has a pre-condition that requires the pointer to have been an arc before
+    //     let arc: Arc<UnsafeCell<dyn PartialReflect>> =
+    //         unsafe { Arc::from_raw(raw_ptr as *const _) };
+    //     let allocation = ReflectAllocation::new(arc);
+    //     self.allocations.insert(id, allocation.clone());
+    //     if let Some(type_id) = type_id {
+    //         self.types.insert(id, type_id);
+    //     }
+    //     (id, allocation)
+    // }
 
     pub fn get(&self, id: ReflectAllocationId) -> Option<ReflectAllocation> {
         self.allocations.get(&id).cloned()

crates/bevy_mod_scripting_core/src/bindings/proxy.rs

@@ -186,14 +186,7 @@ where
     ) -> ScriptResult<Self::Output<'o>> {
         let reflect_ref: &ReflectReference = self.0.as_ref();
         let access = reflect_ref.base.base_id.get_reflect_access_id();
-        let access = guard
-            .get_access_timeout(access, DEFAULT_TIMEOUT, DEFAULT_INTERVAL)
-            .ok_or_else(|| {
-                ScriptError::new_reflection_error(format!(
-                    "Could not unproxy type: `{}`. Aliasing access.",
-                    std::any::type_name::<T>()
-                ))
-            })?;
+        let access = guard.get_access_timeout(access, DEFAULT_TIMEOUT, DEFAULT_INTERVAL);
         let out = reflect_ref.reflect(
             guard.as_unsafe_world_cell(),
             &access,
@@ -248,14 +241,7 @@ where
     ) -> ScriptResult<()> {
         let reflect_ref: &ReflectReference = self.0.as_ref();
         let access = reflect_ref.base.base_id.get_reflect_access_id();
-        let access = guard
-            .get_access_timeout(access, DEFAULT_TIMEOUT, DEFAULT_INTERVAL)
-            .ok_or_else(|| {
-                ScriptError::new_reflection_error(format!(
-                    "Could not unproxy type: `{}`. Aliasing access.",
-                    std::any::type_name::<T>()
-                ))
-            })?;
+        let access = guard.get_access_timeout(access, DEFAULT_TIMEOUT, DEFAULT_INTERVAL);
         accesses.push(access);
         Ok(())
     }
@@ -309,14 +295,7 @@ where
     ) -> ScriptResult<()> {
         let reflect_ref: &ReflectReference = self.0.as_ref();
         let access = reflect_ref.base.base_id.get_reflect_access_id();
-        let access = guard
-            .get_access_timeout(access, DEFAULT_TIMEOUT, DEFAULT_INTERVAL)
-            .ok_or_else(|| {
-                ScriptError::new_reflection_error(format!(
-                    "Could not unproxy type: `{}`. Aliasing access.",
-                    std::any::type_name::<T>()
-                ))
-            })?;
+        let access = guard.get_access_timeout(access, DEFAULT_TIMEOUT, DEFAULT_INTERVAL);
         accesses.push(access);
         Ok(())
     }