From b16bc38caae3a11d36bd295769fea27203200cdb Mon Sep 17 00:00:00 2001
From: baloneysandwiches <alex@bellandwhistle.net>
Date: Tue, 29 Apr 2014 16:47:12 -0700
Subject: [PATCH 1/2] Use <button> for keyboard accessibility

I'm all for having gotten away from <a href="#"> for the pager markup.
That's an accessibility anti-pattern. Anchor hrefs should only point to
external content, not a dummy placeholder.

But elements that have a more-or-less fixed role in loading in-page
content should really just be <button>s. This allows them to default to
conventional CSS focus outlines, and to be sequenced normally in the
tabindex for keyboard-only, non-mouse users. Buttons have much better
out-of-the-box accessibility for elements without ARIA roles:

http://yahoodevelopers.tumblr.com/post/59489724815/easy-fixes-to-common-
accessibility-problems

Also on a humourous, ranty note:

http://www.karlgroves.com/2013/05/14/links-are-not-buttons-neither-are-d
ivs-and-spans/

P.S: I smiled to discover that Builtwith says that cycle (1 & 2
combined) is used on more than 3 million sites. More than Modernizr!
Wow, congrats!
---
 src/jquery.cycle2.pager.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/jquery.cycle2.pager.js b/src/jquery.cycle2.pager.js
index 1732e76..5d066bc 100644
--- a/src/jquery.cycle2.pager.js
+++ b/src/jquery.cycle2.pager.js
@@ -7,7 +7,7 @@ $.extend($.fn.cycle.defaults, {
     pagerActiveClass: 'cycle-pager-active',
     pagerEvent:       'click.cycle',
     pagerEventBubble: undefined,
-    pagerTemplate:    '<span>&bull;</span>'
+    pagerTemplate:    '<button>&bull;</button>'
 });
 
 $(document).on( 'cycle-bootstrap', function( e, opts, API ) {

From ab0e81798634c32707f9b61434171c60e804968f Mon Sep 17 00:00:00 2001
From: Alex Bell <alex@bellandwhistle.net>
Date: Thu, 15 May 2014 12:12:52 -0700
Subject: [PATCH 2/2] throttle initAutoHeight triggered by slide-added

Without throttling, adding a whole bunch of slides in succession (e.g. with loader) can make the sentinel-selection get glitchy.
---
 src/jquery.cycle2.autoheight.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/jquery.cycle2.autoheight.js b/src/jquery.cycle2.autoheight.js
index f7615a8..ebd003e 100644
--- a/src/jquery.cycle2.autoheight.js
+++ b/src/jquery.cycle2.autoheight.js
@@ -18,7 +18,6 @@ $(document).on( 'cycle-initialized', function( e, opts ) {
         return;
 
     // bind events
-    opts.container.on( 'cycle-slide-added cycle-slide-removed', initAutoHeight );
     opts.container.on( 'cycle-destroyed', onDestroy );
 
     if ( autoHeight == 'container' ) {
@@ -31,15 +30,15 @@ $(document).on( 'cycle-initialized', function( e, opts ) {
         opts._autoHeightRatio = ratio;
     }
 
-    // if autoHeight is a number then we don't need to recalculate the sentinel
-    // index on resize
+    // if autoHeight is calc or ratio then we need to recalculate the sentinel
+    // index on resize, and also on slide-added/slide-removed
     if ( t !== 'number' ) {
         // bind unique resize handler per slideshow (so it can be 'off-ed' in onDestroy)
         opts._autoHeightOnResize = function () {
             clearTimeout( resizeThrottle );
             resizeThrottle = setTimeout( onResize, 50 );
         };
-
+        opts.container.on( 'cycle-slide-added cycle-slide-removed', opts._autoHeightOnResize );
         $(window).on( 'resize orientationchange', opts._autoHeightOnResize );
     }