Skip to content

Commit 8a2b1e9

Browse files
committed
ci: linting fixes
1 parent 0513bed commit 8a2b1e9

File tree

5 files changed

+18
-5
lines changed

5 files changed

+18
-5
lines changed

.github/ISSUE_TEMPLATE/issue-template.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,14 @@ labels: ''
66
assignees: ''
77

88
---
9+
You are at the right place to submit an issue about the *dockerization* of micromamba.
10+
If you have an issue about the micromamba program, then this is not the correct place
11+
to submit your issue. Please submit micromamba issues in the
12+
[mamba/libmamba/micromamba issue tracker](https://github.com/mamba-org/mamba/issues).
913

10-
You are at the right place to submit an issue about the *dockerization* of micromamba. If you have an issue about the micromamba program, then this is not the correct place to submit your issue. Please submit micromamba issues in the [mamba/libmamba/micromamba issue tracker](https://github.com/mamba-org/mamba/issues).
14+
Please read our [FAQ](https://github.com/mamba-org/micromamba-docker/blob/main/FAQ.md)
15+
before you create an issue.
1116

12-
Please read our [FAQ](https://github.com/mamba-org/micromamba-docker/blob/main/FAQ.md) before you create an issue.
13-
14-
This repo also has [Discussions](https://github.com/mamba-org/micromamba-docker/discussions) enabled and that may be a more appropriate location if you want to have a more open ended conversation.
17+
This repo also has [Discussions](https://github.com/mamba-org/micromamba-docker/discussions)
18+
enabled and that may be a more appropriate location if you want to have a more open
19+
ended conversation.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Please include an entry in CHANGELOG.md with most pull requests!
1+
# Please include an entry in CHANGELOG.md with most pull requests

.markdownlint_config.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
all
22
rule 'MD026', :punctuation => '.,;:!'
3+
exclude_rule 'MD041'

.pre-commit-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ repos:
4646
rev: v2.13.1-beta
4747
hooks:
4848
- id: hadolint-docker
49+
args: ['--ignore', 'DL3018']
4950
- repo: https://github.com/zizmorcore/zizmor-pre-commit
5051
rev: v1.9.0
5152
hooks:

test/activation-logic.bats

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ setup() {
1919

2020
# Activation should skip in the simplest case when MAMBA_SKIP_ACTIVATE=1.
2121
@test "docker run -e MAMBA_SKIP_ACTIVATE=1 ${MICROMAMBA_IMAGE}-cli-invocations python --version" {
22+
# shellcheck disable=SC2329
2223
f() {
2324
# shellcheck disable=SC2086
2425
docker run $RUN_FLAGS -e MAMBA_SKIP_ACTIVATE=1 "${MICROMAMBA_IMAGE}-cli-invocations" "$@"
@@ -30,6 +31,7 @@ setup() {
3031

3132
# Activation should succeed in an interactive terminal.
3233
@test "'docker run -it ${MICROMAMBA_IMAGE}-cli-invocations' with 'python --version; exit'" {
34+
# shellcheck disable=SC2329
3335
f() {
3436
# shellcheck disable=SC2086
3537
echo -e "$1" | faketty \
@@ -43,6 +45,7 @@ setup() {
4345
# Activation should also succeed in an interactive terminal with the entrypoint
4446
# disabled, thanks to activation in .bashrc.
4547
@test "'docker run -it --entrypoint=/bin/bash ${MICROMAMBA_IMAGE}-cli-invocations' with 'python --version; exit'" {
48+
# shellcheck disable=SC2329
4649
f() {
4750
# shellcheck disable=SC2086
4851
echo -e "$1" | faketty \
@@ -55,6 +58,7 @@ setup() {
5558

5659
# ... Now that we isolated activation to .bashrc, disable it via MAMBA_SKIP_ACTIVATE=1.
5760
@test "'docker run -it --entrypoint=/bin/bash -e MAMBA_SKIP_ACTIVATE=1 ${MICROMAMBA_IMAGE}-cli-invocations' with 'python --version; exit'" {
61+
# shellcheck disable=SC2329
5862
f() {
5963
# shellcheck disable=SC2086
6064
echo -e "$1" | faketty \
@@ -70,6 +74,7 @@ setup() {
7074
# Unlike the interactive terminal above, in a non-interactive terminal, activation skips
7175
# when the entrypoint is overridden because "bash -c" sources .bashrc non-interactively.
7276
@test "docker run --entrypoint='' ${MICROMAMBA_IMAGE}-cli-invocations /bin/bash -c 'python --version'" {
77+
# shellcheck disable=SC2329
7378
f() {
7479
# shellcheck disable=SC2086
7580
docker run $RUN_FLAGS --entrypoint='' "${MICROMAMBA_IMAGE}-cli-invocations" /bin/bash -c "$1"
@@ -87,6 +92,7 @@ setup() {
8792

8893
# ... Verify that MAMBA_SKIP_ACTIVATE=1 correctly skips activation from the entrypoint.
8994
@test "docker run -e MAMBA_SKIP_ACTIVATE=1 ${MICROMAMBA_IMAGE}-cli-invocations /bin/bash -c 'python --version'" {
95+
# shellcheck disable=SC2329
9096
f() {
9197
# shellcheck disable=SC2086
9298
docker run $RUN_FLAGS -e MAMBA_SKIP_ACTIVATE=1 "${MICROMAMBA_IMAGE}-cli-invocations" /bin/bash -c "$1"

0 commit comments

Comments
 (0)