try parsing as json if no content-type headers are present

Author: manwaring

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html)
 
+## [3.6.2]  (2020-06-21)
+
+### Updated
+
+- Try harder to parse api payloads as JSON even if no content-type headers are available
+
 ## [3.6.1]  (2020-06-21)
 
 ### Updated

package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "@manwaring/lambda-wrapper",
   "description": "A lambda handler wrapper to abstract common functionality and provide useful defaults",
-  "version": "3.6.1",
+  "version": "3.6.2",
   "scripts": {
     "publish-please-dry-run": "publish-please --dry-run",
     "publish-please": "publish-please",

package.json

@@ -31,11 +31,11 @@ describe('Body parsing', () => {
     expect(body).toEqual(form);
   });
 
-  it("Passes body through when content type isn't specified", () => {
+  it("Tries to parse body as JSON when content type isn't specified", () => {
     const json = { hello: 'world' };
     const headers = {};
     const body = new Body(JSON.stringify(json), headers).getParsedBody();
-    expect(body).toEqual(JSON.stringify(json));
+    expect(body).toEqual(json);
   });
 
   it("Errors when encoding and content-type don't match", () => {

src/api/parser.test.ts

@@ -42,26 +42,26 @@ export class Body {
         } else if (this.isJSON(contentType)) {
           parsedBody = JSON.parse(this.body);
         } else {
-          logger.error('Content-Type header not found, unable to parse body');
-          parsedBody = this.body;
+          logger.error('Content-Type header not found, attempting to parse as JSON');
+          parsedBody = JSON.parse(this.body);
         }
       } catch (err) {
-        logger.error('Error parsing body', err, this.body);
+        logger.error('Error parsing body, returning as-is', err, this.body);
         parsedBody = this.body;
       }
     }
     return parsedBody;
   }
 
   private getContentType(): string {
-    return this.headers['Content-Type'] || this.headers['CONTENT-TYPE'] || this.headers['content-type'];
+    return this?.headers['Content-Type'] || this?.headers['CONTENT-TYPE'] || this?.headers['content-type'];
   }
 
-  private isFormUrlEncoded(contentType: string): boolean {
-    return contentType && contentType.toUpperCase().includes('APPLICATION/X-WWW-FORM-URLENCODED');
+  private isFormUrlEncoded(contentType?: string): boolean {
+    return contentType?.toUpperCase().includes('APPLICATION/X-WWW-FORM-URLENCODED');
   }
 
   private isJSON(contentType: string): boolean {
-    return contentType && contentType.toUpperCase().includes('APPLICATION/JSON');
+    return contentType?.toUpperCase().includes('APPLICATION/JSON');
   }
 }