Skip to content

Commit 05396b8

Browse files
authored
NavigationMapView initialization fix (#4399)
* vk-NAVIOS-938-carplay-tilestore: fixed NaivgationMapView initialization with correct tilestore setup; updated NN version checkout; CHANGELOG updated
1 parent 5bb326c commit 05396b8

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@
1313
**Note:** The Mapbox Electronic Horizon feature of the Mapbox Navigation SDK is in public beta and is subject to changes, including its pricing. Use of the feature is subject to the beta product restrictions in the Mapbox Terms of Service. Mapbox reserves the right to eliminate any free tier or free evaluation offers at any time and require customers to place an order to purchase the Mapbox Electronic Horizon feature, regardless of the level of use of the feature.
1414
* Added`Interchange.identifier` and `Junction.identifier` fields. ([#4396](https://github.com/mapbox/mapbox-navigation-ios/pull/4396))
1515

16+
### Map
17+
18+
* Fixed an issue when `NavigationMapView` would not display a map, when using CarPlay and custom tile storage location. ([#4399](https://github.com/mapbox/mapbox-navigation-ios/pull/4399))
19+
1620
### Camera
1721

1822
* Fixes an issue where the camera's position was not calculated correctly when banners fully overlapped the map. ([#4400](https://github.com/mapbox/mapbox-navigation-ios/pull/4400))

MapboxNavigation-SPM.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Sources/MapboxNavigation/NavigationMapView.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1720,7 +1720,8 @@ open class NavigationMapView: UIView {
17201720
*/
17211721
public init(frame: CGRect,
17221722
navigationCameraType: NavigationCameraType = .mobile,
1723-
tileStoreLocation: TileStoreConfiguration.Location? = .default) {
1723+
tileStoreLocation: TileStoreConfiguration.Location? = NavigationSettings.shared.tileStoreConfiguration.mapLocation
1724+
) {
17241725
super.init(frame: frame)
17251726
let mapView = makeMapView(
17261727
frame: frame,

Sources/MapboxNavigation/NavigationView.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,8 @@ open class NavigationView: UIView {
222222
- parameter navigationMapView: Custom `NavigationMapView` instance to supersede the default one.
223223
*/
224224
public init(frame: CGRect,
225-
tileStoreLocation: TileStoreConfiguration.Location? = .default,
225+
tileStoreLocation: TileStoreConfiguration.Location? = NavigationSettings.shared.tileStoreConfiguration.mapLocation
226+
,
226227
navigationMapView: NavigationMapView? = nil) {
227228
navigationMapView?.translatesAutoresizingMaskIntoConstraints = false
228229
self.navigationMapView = navigationMapView ?? NavigationMapView(frame: frame, tileStoreLocation: tileStoreLocation)

0 commit comments

Comments
 (0)