Make use of ErrorResponse handling

By using DomainException that we'll get caught
automatically.

Author: marein

assets/js/ConnectFour/Timer.js

@@ -14,7 +14,7 @@ customElements.define('connect-four-timer', class extends HTMLElement {
         this._panicLevelThreeBelowMs = parseInt(this.getAttribute('panic-three-below-ms') || 3000);
         this._currentTickSound = null;
 
-        window.requestAnimationFrame(this._render);
+        this._animationFrameId = window.requestAnimationFrame(this._render);
 
         sse.subscribe(`connect-four-${this.getAttribute('game-id')}`, {
             'ConnectFour.PlayerJoined': this._onPlayerJoined,
@@ -29,6 +29,7 @@ customElements.define('connect-four-timer', class extends HTMLElement {
 
     disconnectedCallback() {
         this._sseAbortController.abort();
+        cancelAnimationFrame(this._animationFrameId);
     }
 
     _render = () => {
@@ -57,7 +58,7 @@ customElements.define('connect-four-timer', class extends HTMLElement {
             scriptune.play(`#BPM 300\nC5:s ${isPanicLevelThree ? '-:s C5:s' : ''}`)
         }
 
-        window.requestAnimationFrame(this._render);
+        this._animationFrameId = window.requestAnimationFrame(this._render);
     }
 
     _onPlayerJoined = e => {

src/ConnectFour/Domain/Game/Board/Size.php

@@ -18,11 +18,11 @@ final class Size
     public function __construct(int $width, int $height)
     {
         if ($width < 2 || $height < 2) {
-            throw new InvalidSizeException('Width and height must be greater then 1.');
+            throw InvalidSizeException::tooSmall($width, $height);
         }
 
         if (($width * $height) % 2 !== 0) {
-            throw new InvalidSizeException('Product of width and height must be an even number.');
+            throw InvalidSizeException::productNotEven($width, $height);
         }
 
         $this->height = $height;

src/ConnectFour/Domain/Game/Exception/ColumnAlreadyFilledException.php

@@ -4,6 +4,13 @@
 
 namespace Gaming\ConnectFour\Domain\Game\Exception;
 
+use Gaming\Common\Domain\Exception\Violation;
+use Gaming\Common\Domain\Exception\Violations;
+
 final class ColumnAlreadyFilledException extends GameException
 {
+    public function __construct()
+    {
+        parent::__construct(new Violations(new Violation('column_already_filled')));
+    }
 }

src/ConnectFour/Domain/Game/Exception/GameException.php

@@ -4,8 +4,8 @@
 
 namespace Gaming\ConnectFour\Domain\Game\Exception;
 
-use Exception;
+use Gaming\Common\Domain\Exception\DomainException;
 
-class GameException extends Exception
+class GameException extends DomainException
 {
 }

src/ConnectFour/Domain/Game/Exception/GameFinishedException.php

@@ -4,6 +4,13 @@
 
 namespace Gaming\ConnectFour\Domain\Game\Exception;
 
+use Gaming\Common\Domain\Exception\Violation;
+use Gaming\Common\Domain\Exception\Violations;
+
 final class GameFinishedException extends GameException
 {
+    public function __construct()
+    {
+        parent::__construct(new Violations(new Violation('game_already_finished')));
+    }
 }

src/ConnectFour/Domain/Game/Exception/GameNotFoundException.php

@@ -4,6 +4,13 @@
 
 namespace Gaming\ConnectFour\Domain\Game\Exception;
 
+use Gaming\Common\Domain\Exception\Violation;
+use Gaming\Common\Domain\Exception\Violations;
+
 final class GameNotFoundException extends GameException
 {
+    public function __construct()
+    {
+        parent::__construct(new Violations(new Violation('game_not_found')));
+    }
 }

src/ConnectFour/Domain/Game/Exception/GameNotRunningException.php

@@ -4,6 +4,13 @@
 
 namespace Gaming\ConnectFour\Domain\Game\Exception;
 
+use Gaming\Common\Domain\Exception\Violation;
+use Gaming\Common\Domain\Exception\Violations;
+
 final class GameNotRunningException extends GameException
 {
+    public function __construct()
+    {
+        parent::__construct(new Violations(new Violation('game_not_running')));
+    }
 }

src/ConnectFour/Domain/Game/Exception/GameRunningException.php

@@ -4,6 +4,13 @@
 
 namespace Gaming\ConnectFour\Domain\Game\Exception;
 
+use Gaming\Common\Domain\Exception\Violation;
+use Gaming\Common\Domain\Exception\Violations;
+
 final class GameRunningException extends GameException
 {
+    public function __construct()
+    {
+        parent::__construct(new Violations(new Violation('game_already_running')));
+    }
 }

src/ConnectFour/Domain/Game/Exception/InvalidSizeException.php

@@ -4,6 +4,31 @@
 
 namespace Gaming\ConnectFour\Domain\Game\Exception;
 
+use Gaming\Common\Domain\Exception\Violation;
+use Gaming\Common\Domain\Exception\ViolationParameter;
+use Gaming\Common\Domain\Exception\Violations;
+
 final class InvalidSizeException extends GameException
 {
+    public function __construct(string $identifier, int $width = 0, int $height = 0)
+    {
+        parent::__construct(
+            new Violations(
+                new Violation($identifier, [
+                    new ViolationParameter('width', $width),
+                    new ViolationParameter('height', $height)
+                ])
+            )
+        );
+    }
+
+    public static function productNotEven(int $width, int $height): self
+    {
+        return new self('invalid_size.not_even', $width, $height);
+    }
+
+    public static function tooSmall(int $width, int $height): self
+    {
+        return new self('invalid_size.too_small', $width, $height);
+    }
 }

src/ConnectFour/Domain/Game/Exception/NoTimeoutException.php

@@ -4,6 +4,13 @@
 
 namespace Gaming\ConnectFour\Domain\Game\Exception;
 
+use Gaming\Common\Domain\Exception\Violation;
+use Gaming\Common\Domain\Exception\Violations;
+
 final class NoTimeoutException extends GameException
 {
+    public function __construct()
+    {
+        parent::__construct(new Violations(new Violation('no_timeout')));
+    }
 }