Skip to content

Encode/decode using JSON instead of Django signed objects #76

@yamin-oanda

Description

@yamin-oanda

When saving the session data:

data = self.encode(self._get_session(no_load=must_create))

And loading the session data:

return self.decode(force_unicode(session_data))

It would be better to use json.dumps() and json.loads() rather than self.encode()/self.decode(). The reason is that the latter pair of inherited methods (encode / decode) are both using Django cryptographic signing/signature verification. This is not really needed when we are saving the session data in Redis because the Redis cache is not going to be accessible to the public. So there is no possibility of bad data entering the cache (leaving aside the Django application deliberately setting bad data).

It would simplify the storage/load if the json serialization functions were used instead. And it would also eliminate the need for using any cryptography.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions