Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Oct 28, 2025

This PR changes the mjx-keep-attrs attribute into a property, since it is only used in the tex input phase, and doesn't need to be exposed as an explicit attribute. It also removes the unused _d argument from the walkTree() call.

@dpvc dpvc requested a review from zorkow October 28, 2025 11:25
@dpvc dpvc added this to the v4.1.0 milestone Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.66%. Comparing base (27c47f3) to head (f5429ea).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1379      +/-   ##
===========================================
- Coverage    86.66%   86.66%   -0.01%     
===========================================
  Files          338      338              
  Lines        84384    84382       -2     
  Branches      4779     3148    -1631     
===========================================
- Hits         73131    73129       -2     
  Misses       11253    11253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit ec084b0 into develop Nov 9, 2025
3 checks passed
@dpvc dpvc deleted the update/keep-attrs branch November 9, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants