Skip to content

Commit 5ced676

Browse files
author
Matthew Shirley
authored
Merge pull request #1 from matthewshirley/develop
👷‍♂️ Implement CI
2 parents d55abb9 + 6b09295 commit 5ced676

File tree

3 files changed

+68
-5
lines changed

3 files changed

+68
-5
lines changed

.github/workflows/publish.yml

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
name: Publish Package
2+
3+
on:
4+
release:
5+
types: [created]
6+
7+
jobs:
8+
build:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- uses: actions/checkout@v2
12+
- uses: actions/setup-node@v1
13+
with:
14+
node-version: 12
15+
- run: yarn install
16+
- run: yarn build
17+
18+
publish-npm:
19+
needs: build
20+
runs-on: ubuntu-latest
21+
steps:
22+
- uses: actions/checkout@v2
23+
- uses: actions/setup-node@v1
24+
with:
25+
node-version: 12
26+
registry-url: https://registry.npmjs.org/
27+
- run: yarn install
28+
- run: yarn publish
29+
env:
30+
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
31+
32+
publish-gpr:
33+
needs: build
34+
runs-on: ubuntu-latest
35+
steps:
36+
- uses: actions/checkout@v2
37+
- uses: actions/setup-node@v1
38+
with:
39+
node-version: 12
40+
registry-url: https://npm.pkg.github.com/
41+
- run: yarn install
42+
- run: yarn publish
43+
env:
44+
NODE_AUTH_TOKEN: ${{secrets.GH_PACKAGES_TOKEN}}

.github/workflows/test.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
name: CI
2+
3+
on: [push, pull_request]
4+
5+
jobs:
6+
test:
7+
runs-on: ubuntu-latest
8+
steps:
9+
- uses: actions/checkout@v2
10+
- uses: actions/setup-node@v1
11+
with:
12+
node-version: "12.x"
13+
- run: yarn install
14+
- run: yarn test
15+
env:
16+
CI: true

src/hooks/useInputs/useInputs.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,14 @@ export default function useInputs(onMessage) {
4040
*
4141
* @param {Number} id
4242
*/
43-
const removeInputById = useCallback((id) => {
44-
return setInputs((previouslyConnected) => [
45-
...previouslyConnected.filter((input) => input.id !== id)
46-
]);
47-
});
43+
const removeInputById = useCallback(
44+
(id) => {
45+
return setInputs((previouslyConnected) => [
46+
...previouslyConnected.filter((input) => input.id !== id)
47+
]);
48+
},
49+
[setInputs]
50+
);
4851

4952
/**
5053
* Routes MIDI device state changes (connection, disconnection)

0 commit comments

Comments
 (0)