prefer builtin-functions for performance

refs GH-80

Author: mmoll

MO4/Sniffs/Arrays/ArrayDoubleArrowAlignmentSniff.php

@@ -84,7 +84,7 @@ public function process(File $phpcsFile, $stackPtr)
             $previous = $tokens[($i - 1)];
 
             // Skip nested arrays.
-            if (in_array($current['code'], $this->arrayTokens, true) === true) {
+            if (\in_array($current['code'], $this->arrayTokens, true) === true) {
                 if ($current['code'] === T_ARRAY) {
                     $i = ($current['parenthesis_closer'] + 1);
                 } else {
@@ -114,7 +114,7 @@ public function process(File $phpcsFile, $stackPtr)
 
                 $j = ($i - 1);
                 while (($j >= 0) && ($tokens[$j]['line'] === $current['line'])) {
-                    if (in_array($tokens[$j]['code'], PHP_CodeSniffer_Tokens::$emptyTokens, true) === false) {
+                    if (\in_array($tokens[$j]['code'], PHP_CodeSniffer_Tokens::$emptyTokens, true) === false) {
                         $hasKeyInLine = true;
                     }
 

MO4/Sniffs/Formatting/AlphabeticalUseStatementsSniff.php

@@ -88,7 +88,7 @@ class AlphabeticalUseStatementsSniff extends UseDeclarationSniff
      */
     public function process(File $phpcsFile, $stackPtr)
     {
-        if (in_array($this->order, $this->supportedOrderingMethods, true) === false) {
+        if (\in_array($this->order, $this->supportedOrderingMethods, true) === false) {
             $error = sprintf(
                 "'%s' is not a valid order function for %s! Pick one of: %s",
                 $this->order,
@@ -369,7 +369,7 @@ private function compareString($a, $b)
      */
     private function dictionaryCompare($a, $b)
     {
-        $min = min(strlen($a), strlen($b));
+        $min = min(\strlen($a), \strlen($b));
 
         for ($i = 0; $i < $min; $i++) {
             if ($a[$i] === $b[$i]) {

MO4/Sniffs/Formatting/UnnecessaryNamespaceUsageSniff.php

@@ -150,7 +150,7 @@ public function process(File $phpcsFile, $stackPtr)
                         -1,
                         PREG_SPLIT_NO_EMPTY
                     );
-                    $docLineTokens = array_slice(
+                    $docLineTokens = \array_slice(
                         $docLineTokens,
                         0,
                         $docCommentTags[$content]
@@ -163,7 +163,7 @@ public function process(File $phpcsFile, $stackPtr)
                             PREG_SPLIT_NO_EMPTY
                         );
                         foreach ($typeTokens as $typeToken) {
-                            if (true === in_array($typeToken, $useStatements, true)) {
+                            if (true === \in_array($typeToken, $useStatements, true)) {
                                 continue;
                             }
 
@@ -365,7 +365,7 @@ private function checkShorthandPossible(
 
             $replaceClassName = true;
         } else if ($namespace !== "" && strpos($fullClassName, $namespace) === 0) {
-            $replacement = substr($fullClassName, strlen($namespace));
+            $replacement = substr($fullClassName, \strlen($namespace));
 
             $data    = [
                 $className,

MO4/Sniffs/Strings/VariableInDoubleQuotedStringSniff.php

@@ -130,7 +130,7 @@ public function process(File $phpcsFile, $stackPtr)
     private function surroundVariableWithBraces($content, $pos, $var)
     {
         $before = substr($content, 0, $pos);
-        $after  = substr($content, ($pos + strlen($var)));
+        $after  = substr($content, ($pos + \strlen($var)));
 
         return $before.'{'.$var.'}'.$after;