PHPStan level 7

Author: swissspidy

phpstan.neon.dist

@@ -1,5 +1,5 @@
 parameters:
-	level: 6
+	level: 7
 	paths:
 		- ai-command.php
 		- src/

src/AI/AiClient.php

@@ -142,9 +142,9 @@ static function () {
 
 			$text = '';
 
-			$content = $candidates->get( 0 )->get_content() ?? [];
+			$parts = $candidates->get( 0 )->get_content()?->get_parts() ?? new Parts();
 
-			foreach ( $content->get_parts() as $part ) {
+			foreach ( $parts as $part ) {
 				if ( $part instanceof Text_Part ) {
 					if ( '' !== $text ) {
 						$text .= "\n\n";

src/AiCommand.php

@@ -99,7 +99,12 @@ protected function get_tools( array $sessions ): array {
 
 		foreach ( $sessions as $name => $session ) {
 			foreach ( $session->listTools()->tools as $mcp_tool ) {
-				$parameters = json_decode( json_encode( $mcp_tool->inputSchema->jsonSerialize() ), true );
+				$parameters = json_decode(
+					json_encode( $mcp_tool->inputSchema->jsonSerialize(), JSON_THROW_ON_ERROR ),
+					true,
+					512,
+					JSON_THROW_ON_ERROR
+				);
 				unset( $parameters['additionalProperties'], $parameters['$schema'] );
 
 				// Not having any properties doesn't seem to work.
@@ -127,7 +132,12 @@ protected function get_tools( array $sessions ): array {
 
 						// To trigger the jsonSerialize() methods.
 						// TODO: Return all array items, not just first one.
-						return json_decode( json_encode( $result->content[0] ), true );
+						return json_decode(
+							json_encode( $result->content[0], JSON_THROW_ON_ERROR ),
+							true,
+							512,
+							JSON_THROW_ON_ERROR
+						);
 					},
 				];
 			}

src/MCP/Client.php

@@ -63,7 +63,9 @@ public function connect(
 		// phpcs:ignore WordPress.WP.AlternativeFunctions.parse_url_parse_url
 		$url_parts = parse_url( $command_or_url );
 
-		if ( isset( $url_parts['scheme'] ) && in_array( strtolower( $url_parts['scheme'] ), [ 'http', 'https' ], true ) ) {
+		if (
+			isset( $url_parts['scheme'], $url_parts['host'] ) && in_array( strtolower( $url_parts['scheme'] ), [ 'http', 'https' ], true )
+		) {
 			$options = [
 				// Just for local debugging.
 				'verify' => false,
@@ -72,7 +74,7 @@ public function connect(
 				$options['auth'] = [ $url_parts['user'], $url_parts['pass'] ];
 			}
 
-			$url = $url_parts['scheme'] . '://' . $url_parts['host'] . $url_parts['path'];
+			$url = $url_parts['scheme'] . '://' . $url_parts['host'] . ( $url_parts['path'] ?? '' );
 
 			$transport = new HttpTransport( $url, $options, $this->logger );
 

src/MCP/Servers/WP_CLI/Tools/CliCommands.php

@@ -47,7 +47,13 @@ public function get_tools(): array {
 
 				$command_desc     = $command->get_shortdesc();
 				$command_synopsis = $command->get_synopsis();
-				$synopsis_spec    = SynopsisParser::parse( $command_synopsis );
+
+				/**
+				 * Parsed synopsys.
+				 *
+				 * @var array<int, array{optional?: bool, type: string, repeating: bool, name: string}> $synopsis_spec
+				 */
+				$synopsis_spec = SynopsisParser::parse( $command_synopsis );
 
 				$properties = [];
 				$required   = [];
@@ -64,7 +70,7 @@ public function get_tools(): array {
 						$prop_name                = str_replace( '-', '_', $arg['name'] );
 						$properties[ $prop_name ] = [
 							'type'        => 'string',
-							'description' => $arg['description'] ?? "Parameter {$arg['name']}",
+							'description' => "Parameter {$arg['name']}",
 						];
 
 						if ( ! isset( $arg['optional'] ) || ! $arg['optional'] ) {
@@ -133,7 +139,13 @@ public function get_tools(): array {
 					$subcommand_name     = $subcommand->get_name();
 					$subcommand_desc     = $subcommand->get_shortdesc() ?? "Runs WP-CLI command: $subcommand_name";
 					$subcommand_synopsis = $subcommand->get_synopsis();
-					$synopsis_spec       = SynopsisParser::parse( $subcommand_synopsis );
+
+					/**
+					 * Parsed synopsys.
+					 *
+					 * @var array<int, array{optional?: bool, type: string, repeating: bool, name: string}> $synopsis_spec
+					 */
+					$synopsis_spec = SynopsisParser::parse( $subcommand_synopsis );
 
 					$properties = [];
 					$required   = [];
@@ -149,7 +161,7 @@ public function get_tools(): array {
 						if ( 'positional' === $arg['type'] || 'assoc' === $arg['type'] ) {
 							$properties[ $prop_name ] = [
 								'type'        => 'string',
-								'description' => $arg['description'] ?? "Parameter {$arg['name']}",
+								'description' => "Parameter {$arg['name']}",
 							];
 						}
 

src/Utils/McpConfig.php

@@ -25,7 +25,12 @@ public function get_config() {
 		}
 
 		$json_content = file_get_contents( $config_file );
-		$config       = json_decode( $json_content, true );
+
+		if ( false === $json_content ) {
+			return [];
+		}
+
+		$config = json_decode( $json_content, true, 512, JSON_THROW_ON_ERROR );
 		return null !== $config ? (array) $config : [];
 	}