From e147684d89b5eecb5f5d216e6aed4eb450b56da7 Mon Sep 17 00:00:00 2001 From: Claas Augner Date: Thu, 9 Oct 2025 16:27:47 +0200 Subject: [PATCH 1/6] chore(CODEOWNERS): add Engineering for workflows and CODEOWNERS --- .github/CODEOWNERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7014136..a358cf0 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -15,3 +15,6 @@ # If another reviewer is specified, update the PAT token or auto-merge will cease to be automatic. package.json @mdn-bot package-lock.json @mdn-bot + +/.github/workflows/ @mdn/engineering +/.github/CODEOWNERS @mdn/core-dev @mdn/engineering From 0355a4a7f8d3171a4c88ac342965409947f4bc8b Mon Sep 17 00:00:00 2001 From: Claas Augner <495429+caugner@users.noreply.github.com> Date: Thu, 9 Oct 2025 16:28:35 +0200 Subject: [PATCH 2/6] Move engineering codeowners up --- .github/CODEOWNERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index a358cf0..ed107b5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -11,10 +11,10 @@ # ---------------------------------------------------------------------------- * @mdn/core-dev +/.github/workflows/ @mdn/engineering +/.github/CODEOWNERS @mdn/core-dev @mdn/engineering + # These are @mdn-bot because the auto-merge GHA workflow uses the PAT of this account. # If another reviewer is specified, update the PAT token or auto-merge will cease to be automatic. package.json @mdn-bot package-lock.json @mdn-bot - -/.github/workflows/ @mdn/engineering -/.github/CODEOWNERS @mdn/core-dev @mdn/engineering From 9ad57e9831202364f073e3dea81ce4857a7ea51b Mon Sep 17 00:00:00 2001 From: Claas Augner <495429+caugner@users.noreply.github.com> Date: Mon, 13 Oct 2025 09:40:42 +0200 Subject: [PATCH 3/6] chore(CODEOWNERS): replace mdn/{core-dev => engineering} --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index ed107b5..96f495b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -9,7 +9,7 @@ # ---------------------------------------------------------------------------- # DEFAULT OWNERS # ---------------------------------------------------------------------------- -* @mdn/core-dev +* @mdn/engineering /.github/workflows/ @mdn/engineering /.github/CODEOWNERS @mdn/core-dev @mdn/engineering From a2e65e1abea8206932471da453f81caa2800b00b Mon Sep 17 00:00:00 2001 From: Claas Augner <495429+caugner@users.noreply.github.com> Date: Mon, 13 Oct 2025 09:41:14 +0200 Subject: [PATCH 4/6] chore(CODEOWNERS): remove unnecessary default owners comment --- .github/CODEOWNERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 96f495b..1b1a00c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -6,9 +6,6 @@ # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners # ---------------------------------------------------------------------------- -# ---------------------------------------------------------------------------- -# DEFAULT OWNERS -# ---------------------------------------------------------------------------- * @mdn/engineering /.github/workflows/ @mdn/engineering From cf5b639e7eb87560375abb10d25f3fec123c7002 Mon Sep 17 00:00:00 2001 From: Claas Augner <495429+caugner@users.noreply.github.com> Date: Mon, 13 Oct 2025 09:42:17 +0200 Subject: [PATCH 5/6] chore(CODEOWNERS): remove obsolete rules --- .github/CODEOWNERS | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 1b1a00c..e999a67 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -8,9 +8,6 @@ * @mdn/engineering -/.github/workflows/ @mdn/engineering -/.github/CODEOWNERS @mdn/core-dev @mdn/engineering - # These are @mdn-bot because the auto-merge GHA workflow uses the PAT of this account. # If another reviewer is specified, update the PAT token or auto-merge will cease to be automatic. package.json @mdn-bot From ff952b9340094c2cd8c592e818047a03c8c50065 Mon Sep 17 00:00:00 2001 From: Claas Augner <495429+caugner@users.noreply.github.com> Date: Mon, 13 Oct 2025 20:09:33 +0200 Subject: [PATCH 6/6] fix(CODEOWNERS): add Engineering for dependencies --- .github/CODEOWNERS | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index e999a67..617176a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -6,9 +6,7 @@ # https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners # ---------------------------------------------------------------------------- -* @mdn/engineering +* @mdn/engineering -# These are @mdn-bot because the auto-merge GHA workflow uses the PAT of this account. -# If another reviewer is specified, update the PAT token or auto-merge will cease to be automatic. -package.json @mdn-bot -package-lock.json @mdn-bot +package.json @mdn/engineering @mdn-bot +package-lock.json @mdn/engineering @mdn-bot