Skip to content

Commit ec21b35

Browse files
bonzinidcbaker
authored andcommitted
test cases/rust: adjust expected installed paths for shared libraries
Make sure that they are checked against the correct extension on Darwin. Fixes: #7964 Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent 2189ab0 commit ec21b35

File tree

6 files changed

+13
-30
lines changed

6 files changed

+13
-30
lines changed

test cases/rust/13 external c dependencies/meson.build

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
project('rust linking to c using dependency', 'c', 'rust')
22

3-
if host_machine.system() == 'darwin'
4-
error('MESON_SKIP_TEST: does not work right on macos, please fix!')
5-
endif
6-
73
dep_zlib = dependency('zlib', static : get_option('static'), method : get_option('method'), required : false)
84
if not dep_zlib.found()
95
error('MESON_SKIP_TEST: Could not find a @0@ zlib'.format(get_option('static') ? 'static' : 'shared'))

test cases/rust/14 external libm/meson.build

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
project('rust linking to libm', 'c', 'rust')
22

3-
if host_machine.system() == 'darwin'
4-
error('MESON_SKIP_TEST: does not work right on macos, please fix!')
5-
endif
6-
73
cc = meson.get_compiler('c')
84
dep_m = cc.find_library('m', required : false, static : get_option('static'))
95
if not dep_m.found()

test cases/rust/2 sharedlib/meson.build

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
project('rust shared library', 'rust', 'c')
22

3-
if host_machine.system() == 'darwin'
4-
error('MESON_SKIP_TEST: does not work right on macos, please fix!')
5-
endif
6-
73
s = static_library('static', 'value.c')
84
l = shared_library('stuff', 'stuff.rs', link_whole : s, install : true)
95
e = executable('prog', 'prog.rs', link_with : l, install : true)

test cases/rust/2 sharedlib/test.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"installed": [
33
{"type": "exe", "file": "usr/bin/prog"},
44
{"type": "pdb", "file": "usr/bin/prog"},
5-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff.so"},
5+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff"},
66
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff.dll"},
77
{"type": "pdb", "file": "usr/bin/stuff"},
88
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff.dll.lib"}

test cases/rust/4 polyglot/meson.build

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
project('rust and c polyglot executable', 'c', 'rust')
22

3-
if host_machine.system() == 'darwin'
4-
error('MESON_SKIP_TEST: does not work right on macos, please fix!')
5-
endif
6-
73
cc = meson.get_compiler('c')
84

95
# Test all combinations of crate and target types.

test cases/rust/4 polyglot/test.json

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
{"type": "exe", "file": "usr/bin/prog-stuff_clib_both_libraries"},
44
{"type": "pdb", "file": "usr/bin/prog-stuff_clib_both_libraries"},
55
{"type": "pdb", "file": "usr/bin/stuff_clib_both_libraries.pdb"},
6-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_clib_both_libraries.so"},
6+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_clib_both_libraries"},
77
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_clib_both_libraries.dll"},
88
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_clib_both_libraries.dll.lib"},
99
{"type": "file", "file": "usr/lib/libstuff_clib_both_libraries.a"},
1010

1111
{"type": "exe", "file": "usr/bin/prog-stuff_clib_shared_library"},
1212
{"type": "pdb", "file": "usr/bin/prog-stuff_clib_shared_library"},
1313
{"type": "pdb", "file": "usr/bin/stuff_clib_shared_library.pdb"},
14-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_clib_shared_library.so"},
14+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_clib_shared_library"},
1515
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_clib_shared_library.dll"},
1616
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_clib_shared_library.dll.lib"},
1717

@@ -22,7 +22,7 @@
2222
{"type": "exe", "file": "usr/bin/prog-stuff_cdylib_shared_library"},
2323
{"type": "pdb", "file": "usr/bin/prog-stuff_cdylib_shared_library"},
2424
{"type": "pdb", "file": "usr/bin/stuff_cdylib_shared_library.pdb"},
25-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_cdylib_shared_library.so"},
25+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_cdylib_shared_library"},
2626
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_cdylib_shared_library.dll"},
2727
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_cdylib_shared_library.dll.lib"},
2828

@@ -31,7 +31,7 @@
3131
{"type": "file", "file": "usr/lib/libstuff_staticlib_static_library.a"},
3232

3333
{"type": "pdb", "file": "usr/bin/stuff__both_libraries.pdb"},
34-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff__both_libraries.so"},
34+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff__both_libraries"},
3535
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff__both_libraries.rlib"},
3636
{"type": "file", "platform": "msvc", "file": "usr/lib/libstuff__both_libraries.rlib"},
3737
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff__both_libraries.dll"},
@@ -41,13 +41,13 @@
4141
{"type": "file", "platform": "msvc", "file": "usr/lib/libstuff__static_library.rlib"},
4242

4343
{"type": "pdb", "file": "usr/bin/stuff_proc_macro_shared_library.pdb"},
44-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_proc_macro_shared_library.so"},
44+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_proc_macro_shared_library"},
4545
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_proc_macro_shared_library.dll"},
4646
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_proc_macro_shared_library.dll.lib"},
4747

4848
{"type": "pdb", "file": "usr/bin/stuff_lib_both_libraries.pdb"},
4949
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_lib_both_libraries.rlib"},
50-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_lib_both_libraries.so"},
50+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_lib_both_libraries"},
5151
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_lib_both_libraries.dll"},
5252
{"type": "file", "platform": "msvc", "file": "usr/lib/libstuff_lib_both_libraries.rlib"},
5353
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_lib_both_libraries.dll.lib"},
@@ -59,33 +59,32 @@
5959
{"type": "file", "platform": "msvc", "file": "usr/lib/libstuff_lib_static_library.rlib"},
6060

6161
{"type": "pdb", "file": "usr/bin/stuff__shared_library.pdb"},
62-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff__shared_library.so"},
62+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff__shared_library"},
6363
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff__shared_library.dll"},
6464
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff__shared_library.dll.lib"},
6565

6666
{"type": "pdb", "file": "usr/bin/stuff_lib_shared_library.pdb"},
67-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_lib_shared_library.so"},
67+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_lib_shared_library"},
6868
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_lib_shared_library.dll"},
6969
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_lib_shared_library.dll.lib"},
7070

7171
{"type": "pdb", "file": "usr/bin/stuff_dylib_shared_library.pdb"},
72-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_dylib_shared_library.so"},
72+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_dylib_shared_library"},
7373
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_dylib_shared_library.dll.lib"},
7474
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_dylib_shared_library.dll"},
7575

7676
{"type": "pdb", "file": "usr/bin/stuff_cdylib_both_libraries.pdb"},
77-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_cdylib_both_libraries.so"},
78-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_cdylib_both_libraries.so"},
77+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_cdylib_both_libraries"},
7978
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_cdylib_both_libraries.dll"},
8079
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_cdylib_both_libraries.dll.lib"},
8180

8281
{"type": "pdb", "file": "usr/bin/stuff_proc_macro_both_libraries.pdb"},
83-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_proc_macro_both_libraries.so"},
82+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_proc_macro_both_libraries"},
8483
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_proc_macro_both_libraries.dll"},
8584
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_proc_macro_both_libraries.dll.lib"},
8685

8786
{"type": "pdb", "file": "usr/bin/stuff_dylib_both_libraries.pdb"},
88-
{"type": "file", "platform": "gcc", "file": "usr/lib/libstuff_dylib_both_libraries.so"},
87+
{"type": "shared_lib", "platform": "gcc", "file": "usr/lib/stuff_dylib_both_libraries"},
8988
{"type": "file", "platform": "msvc", "file": "usr/bin/stuff_dylib_both_libraries.dll"},
9089
{"type": "file", "platform": "msvc", "file": "usr/lib/stuff_dylib_both_libraries.dll.lib"}
9190
]

0 commit comments

Comments
 (0)