Skip to content

Commit 097cd65

Browse files
: GHA: pin torch-2.9.0 (#1742)
Summary: yesterday's fix D86025607 is flaky. today's observed behavior shows the torch API still suffers from caching / runner variability. this fix is more authoritative: pin torch to 2.9.0 (stable): replace `pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu126` with `pip install torch==2.9.0+cu126 --index-url https://download.pytorch.org/whl/cu126` pulling "nightly" exposes us to non-determinism. relying on a published version restores hermeticity. anyone can stamp/land and we should expect to recover green actions. Differential Revision: D86052365
1 parent f40f6db commit 097cd65

File tree

8 files changed

+15
-9
lines changed

8 files changed

+15
-9
lines changed

.github/workflows/build-cpu.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ jobs:
2929
# Setup build environment (conda + system deps + rust + build deps)
3030
setup_build_environment
3131
32-
# Install torch nightly (CPU version)
33-
pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu
32+
# Install torch 2.9.0 (CPU version) (versioned wheel preferred
33+
# for build hermeticity)
34+
pip install torch==2.9.0+cpu --index-url https://download.pytorch.org/whl/cpu
3435
pip install -r build-requirements.txt
3536
3637
# Build monarch (No tensor engine, CPU version)

.github/workflows/build-cuda.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
include:
1818
- name: 4xlargegpu
1919
runs-on: linux.g5.4xlarge.nvidia.gpu
20-
torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/cu126'
20+
torch-spec: 'torch==2.9.0+cu126 --index-url https://download.pytorch.org/whl/cu126'
2121
gpu-arch-type: "cuda"
2222
gpu-arch-version: "12.6"
2323
with:

.github/workflows/doc_build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
pip install -r docs/requirements.txt
4040
4141
# Install PyTorch with CUDA support (matching build-cuda.yml)
42-
pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu126
42+
pip install torch==2.9.0+cu126 --index-url https://download.pytorch.org/whl/cu126
4343
4444
# Set environment variables for CUDA build
4545
export USE_CUDA=1

.github/workflows/test-cpu-python.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
export USE_TENSOR_ENGINE=0
3333
3434
# Install PyTorch nightly
35-
pip install --pre torch --index-url https://download.pytorch.org/whl/nightly/cpu
35+
pip install torch==2.9.0+cpu --index-url https://download.pytorch.org/whl/cpu
3636
3737
# Install the built wheel from artifact
3838
install_wheel_from_artifact

.github/workflows/test-gpu-python.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
include:
2323
- name: 4xlargegpu
2424
runs-on: linux.g5.4xlarge.nvidia.gpu
25-
torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/cu126'
25+
torch-spec: 'torch==2.9.0+cu126 --index-url https://download.pytorch.org/whl/cu126'
2626
gpu-arch-type: "cuda"
2727
gpu-arch-version: "12.6"
2828
with:

.github/workflows/test-gpu-rust.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
include:
2323
- name: 4xlargegpu
2424
runs-on: linux.g5.4xlarge.nvidia.gpu
25-
torch-spec: '--pre torch --index-url https://download.pytorch.org/whl/nightly/cu126'
25+
torch-spec: 'torch==2.9.0+cu126 --index-url https://download.pytorch.org/whl/cu126'
2626
gpu-arch-type: "cuda"
2727
gpu-arch-version: "12.6"
2828
with:

.github/workflows/wheels.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
include:
2222
- name: 4xlarge
2323
runs-on: linux.g5.4xlarge.nvidia.gpu
24-
install-args: '--pre --extra-index-url https://download.pytorch.org/whl/nightly/cu126'
24+
install-args: 'torch==2.9.0+cu126 --index-url https://download.pytorch.org/whl/cu126'
2525
gpu-arch-type: "cuda"
2626
gpu-arch-version: "12.6"
2727
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
@@ -35,6 +35,7 @@ jobs:
3535
script: |
3636
source scripts/common-setup.sh
3737
setup_build_environment ${{ matrix.python-version }} "${{ matrix.install-args }}"
38+
pip install -r build-requirements.txt
3839
3940
# Setup Tensor Engine dependencies
4041
setup_tensor_engine

scripts/common-setup.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ setup_tensor_engine() {
6464
# Install PyTorch with C++ development headers (libtorch) for Rust compilation
6565
setup_pytorch_with_headers() {
6666
local gpu_arch_version=${1:-"12.6"}
67-
local torch_spec=${2:-"--pre torch --index-url https://download.pytorch.org/whl/nightly/cu126"}
67+
local torch_spec=${2:-"torch==2.9.0+cu126 --index-url https://download.pytorch.org/whl/cu126"}
6868

6969
echo "Setting up PyTorch with C++ headers (GPU arch: ${gpu_arch_version})..."
7070

@@ -110,6 +110,10 @@ setup_build_environment() {
110110
setup_conda_environment "${python_version}"
111111
install_system_dependencies
112112
setup_rust_toolchain
113+
if [ -n "$install_args" ]; then
114+
echo "Installing PyTorch with: ${install_args}"
115+
pip install ${install_args}
116+
fi
113117
}
114118

115119
# Detect and configure CUDA environment for linking

0 commit comments

Comments
 (0)