v1/logging: avoid spinning up LogForwardActor mesh when redundant (#1722)

Summary: Pull Request resolved: #1722

Differential Revision: D85919326

Author: shayne-fletcher

hyperactor_mesh/Cargo.toml

@@ -63,11 +63,13 @@ hyperactor_mesh_macros = { version = "0.0.0", path = "../hyperactor_mesh_macros"
 hyperactor_telemetry = { version = "0.0.0", path = "../hyperactor_telemetry" }
 libc = "0.2.139"
 mockall = "0.13.1"
+monarch_hyperactor = { version = "0.0.0", path = "../monarch_hyperactor" }
 ndslice = { version = "0.0.0", path = "../ndslice" }
 nix = { version = "0.30.1", features = ["dir", "event", "hostname", "inotify", "ioctl", "mman", "mount", "net", "poll", "ptrace", "reboot", "resource", "sched", "signal", "term", "time", "user", "zerocopy"] }
 opentelemetry = "0.29"
 pin-project = "1.1.10"
 preempt_rwlock = { version = "0.0.0", path = "../preempt_rwlock" }
+pyo3 = { version = "0.24", features = ["anyhow", "multiple-pymethods", "py-clone"] }
 rand = { version = "0.8", features = ["small_rng"] }
 serde = { version = "1.0.219", features = ["derive", "rc"] }
 serde_bytes = "0.11"

hyperactor_mesh/test/bootstrap.rs

@@ -6,6 +6,19 @@
  * LICENSE file in the root directory of this source tree.
  */
 
+// Make sure this binary pulls in monarch_hyperactor's attr registry
+// (inventory::submit! side effects). With LTO / linker GC, just
+// adding the crate as a dep is not enough: if nothing in this binary
+// references it, the linker will drop it and its AttrKeyInfo
+// submissions will never register. Touching a symbol makes the linker
+// keep the crate. Issue
+// https://github.com/dtolnay/inventory/issues/7 says this shouldn't
+// be necessary (see also D71096199).
+#[allow(dead_code)]
+fn _link_monarch_hyperactor_attrs() {
+    let _ = monarch_hyperactor::pytokio::UNAWAITED_PYTOKIO_TRACEBACK.name();
+}
+
 /// This is an "empty shell" bootstrap process,
 /// simply invoking [`hyperactor_mesh::bootstrap_or_die`].
 #[tokio::main]
@@ -20,5 +33,9 @@ async fn main() {
         libc::signal(libc::SIGTERM, libc::SIG_DFL);
     }
 
+    // For Procs with embededded python. Safe to call even if it is
+    // never actually used.
+    pyo3::prepare_freethreaded_python();
+
     hyperactor_mesh::bootstrap_or_die().await;
 }

monarch_hyperactor/Cargo.toml

@@ -52,6 +52,7 @@ tokio-util = { version = "0.7.15", features = ["full"] }
 tracing = { version = "0.1.41", features = ["attributes", "valuable"] }
 
 [dev-dependencies]
+buck-resources = "1"
 dir-diff = "0.3"
 
 [features]