attrs: use exe.display() in error msg; good enough (#1723)

Summary:
Pull Request resolved: #1723

per comment https://www.internalfb.com/diff/D85913786?dst_version_fbid=1825525151667784&transaction_fbid=802048042617906, use `p.display()`. its "good enough" (and in fact arguably better).

Reviewed By: mariusae

Differential Revision: D85957620

fbshipit-source-id: ef2c4ed8cf97e88eac18b5f22d8110201b5e5b06

Author: shayne-fletcher

hyperactor/src/attrs.rs

@@ -629,7 +629,7 @@ impl<'de> Visitor<'de> for AttrsVisitor {
 
         let exe_name = std::env::current_exe()
             .ok()
-            .and_then(|p| p.file_name().map(|os| os.to_string_lossy().to_string()))
+            .map(|p| p.display().to_string())
             .unwrap_or_else(|| "<unknown-exe>".to_string());
 
         let mut attrs = Attrs::new();
@@ -1263,8 +1263,14 @@ mod tests {
         let err = bincode::deserialize::<Attrs>(&wire_bytes)
             .expect_err("should error on unknown attr key");
 
+        let exe_str = std::env::current_exe()
+            .ok()
+            .map(|p| p.display().to_string())
+            .unwrap_or_else(|| "<unknown-exe>".to_string());
         let msg = format!("{err}");
+
         assert!(msg.contains("unknown attr key"), "got: {msg}");
         assert!(msg.contains(bad_key), "got: {msg}");
+        assert!(msg.contains(&exe_str), "got: {msg}");
     }
 }